Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate for Meteor 3.0 #306

Merged
merged 78 commits into from
Dec 6, 2024
Merged

Migrate for Meteor 3.0 #306

merged 78 commits into from
Dec 6, 2024

Conversation

jankapunkt
Copy link
Member

@jankapunkt jankapunkt commented Jan 4, 2024 •
edited by StorytellerCZ
Loading

Continuing from #309

StorytellerCZ
StorytellerCZ requested changes Jan 15, 2024
View reviewed changes
package.js Outdated Show resolved Hide resolved
@nachocodoner nachocodoner mentioned this pull request Feb 29, 2024
Closed
3 tasks
@StorytellerCZ StorytellerCZ mentioned this pull request May 26, 2024
Merged
@jankapunkt
Copy link
Member Author

Once CI runs we should release a beta asap, wdyt @StorytellerCZ

@StorytellerCZ
Copy link
Member

Merged in from #309 as I couldn't push to the original branch for some reason.
There are several breaking changes.

@alisnic alisnic mentioned this pull request Jun 13, 2024
Closed
@StorytellerCZ
Copy link
Member

@bhunjadi I will be watching your fork if anything comes up. I will release a beta shortly, but given that the tests and lint fail we have to look into that @jankapunkt

@StorytellerCZ
Copy link
Member

So pretty sure now that the latest rc caused my website to fall into infinite loading. Not sure why, but reverting to rc.4 fixed the issue.

@mcorbelli
Copy link

mcorbelli commented Oct 28, 2024 •
edited
Loading

Any news? Rc4 works well on my project. I have not detected any problems

@harryadel
Copy link
Member

@mcorbelli Currently, it mostly runs fine and doesn't collide with montiapm but at my company's project the test suit always fails when we add the latest beta and I've not had enough time lately to continue digging in. So, I hope you guys give it a spin and open up PRs/help out if you find anything.

@vparpoil vparpoil mentioned this pull request Nov 3, 2024
Merged
@harryadel
Copy link
Member

Published a new beta that includes @jankapunkt great fix #319

@harryadel
Merge pull request #318 from vparpoil/migrate/3.0-beforeFind
7a42f99 
Migrate/3.0 - fix: proposal to keep before.find operations sync
@harryadel
Publish new beta
8b787ab
@harryadel
Copy link
Member

A new beta has been published 2.0.0-rc.6 that includes @vparpoil fix, please give it a try. If everything is ok, I'll do a full release!

StorytellerCZ
StorytellerCZ approved these changes Dec 6, 2024
View reviewed changes
Copy link
Member

@StorytellerCZ StorytellerCZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Time to release!

@StorytellerCZ StorytellerCZ merged commit e02c9c0 into master Dec 6, 2024
4 checks passed
@StorytellerCZ StorytellerCZ deleted the migrate/3.0 branch December 6, 2024 12:49
@StorytellerCZ
Copy link
Member

Thank you everyone who has contributed! v2.0.0 is now live!

@StorytellerCZ
Copy link
Member

@jankapunkt @harryadel after merger the tests started to fail. Can you please check what might be going on? Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harryadel harryadel harryadel left review comments

@vparpoil vparpoil vparpoil left review comments

@srushti18shah srushti18shah srushti18shah approved these changes

@StorytellerCZ StorytellerCZ StorytellerCZ approved these changes

Assignees
No one assigned
Labels
Help wanted Help with this issue is very much appreciated and sough out.
Projects
None yet
Milestone
No milestone