Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add types #459

Merged
merged 3 commits into from
Nov 21, 2024
Merged

Add types #459

merged 3 commits into from
Nov 21, 2024

Conversation

merlinstardust
Copy link
Contributor

@merlinstardust merlinstardust commented Nov 7, 2024 •
edited
Loading

Table of Contents generated with DocToc

What

Adds TypeScript Support. Handles #458

Why

Meteor has added TypeScript Support so this package should support it as well

@harryadel
Copy link
Member

Is this considered done?

StorytellerCZ
StorytellerCZ requested changes Nov 12, 2024
View reviewed changes
Copy link
Member

@StorytellerCZ StorytellerCZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the package is not Typescript I'm not sure if this will be enough, but at least it is a start.

package/collection2/package.js Outdated Show resolved Hide resolved
@merlinstardust
Copy link
Contributor Author

Fixed the name and conflicts. I also don't know if it will be enough but wanted to get things started

@jankapunkt jankapunkt merged commit 419ce5c into Meteor-Community-Packages:master Nov 21, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StorytellerCZ StorytellerCZ StorytellerCZ approved these changes

@jankapunkt jankapunkt jankapunkt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@merlinstardust @harryadel @jankapunkt @StorytellerCZ