Merge pull request #182 from manueltimita/master

Reversing #177 & additional tests

README.md

@@ -269,6 +269,16 @@ This package is great for publishing small sets of related documents. If you use
 
 You will not be able to access `this.userId` inside your `find` functions if you use [arrow functions](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Functions/Arrow_functions).
 
+## Testing
+
+Run the following:
+```shell
+meteor test-packages reywood:publish-composite --driver-package meteortesting:mocha
+```
+The tests are executing a combination of methods and subscriptions. The quickest option was to add a pause after each
+operation (see usage of `sleep()` in `./tests/server.js`), to allow for the publications to send down all the
+documents. However, this is flaky, so you may want to refresh the browser if you notice tests failing for no 
+apparent reason.
 
 ## Reporting issues/bugs
 

lib/subscription.js

@@ -23,8 +23,7 @@ class Subscription {
   added (collectionName, doc) {
     this.refCounter.increment(collectionName, doc._id)
 
-    const existingDoc = this.docHash[buildHashKey(collectionName, doc.id)]
-    if (!existingDoc) {
+    if (this._hasDocChanged(collectionName, doc._id, doc)) {
       debugLog('Subscription.added', `${collectionName}:${doc._id}`)
       this.meteorSub.added(collectionName, doc._id, doc)
       this._addDocHash(collectionName, doc)

package.js

@@ -36,8 +36,6 @@ Package.onUse((api) => {
 // meteor test-packages reywood:publish-composite --driver-package meteortesting:mocha
 Package.onTest((api) => {
   Npm.depends({
-    'lodash.isequal': '4.5.0',
-    'chai-as-promised': '7.1.1',
     chai: '4.3.10'
   })
   api.use([