Update tests #173
Merged
Update tests #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Migrated tests so they are compatible with async/await. Note that some are still failing, due to to issue #175
|
I saw this a little too late. I just submitted #176. Maybe we should close that one and work on this branch. Let me know |
Merged
|
Let's merge #176 into here and then you can continue from here if there is anything left. |
|
@StorytellerCZ Needs a minor fix in |
|
@manueltimita yes please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update tests for async and get them into GitHub Actions
Still a lot of work to do here. If you are interested, you can take over.