Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration for compatibility with Meteor 3.0 #40

Open
wants to merge 23 commits into
base: master
Choose a base branch
from

Conversation

jankapunkt
Copy link
Member

@jankapunkt jankapunkt commented Jan 4, 2024

  • upgraded deps to Meteor 3.0
  • updated docs
  • updated tests

@harryadel
Copy link
Member

Hello Jan, I just the latest version to my application and seems to be working nicely so far. The only problem is that you had fixed the version to 3.0 and we're yet to make the leap so I had to fork it locally and modify these lines:

  api.versionsFrom(['3.0-beta.0'])
  api.use([
    'ecmascript@0.16.8-beta300.0',
    'mongo@2.0.0-beta300.0',
    'lai:collection-extensions@1.0.0-beta300.0'])

to:

api.versionsFrom(['3.0-beta.0'])
  api.use([
    'ecmascript@0.16.8',
    'mongo@1.16.8',
    'lai:collection-extensions@1.0.0-beta300.0'])
  api.addFiles('mongo-instances.js')

and I had to do the same for lai:collection-extensions so my recommendation is drop the 3.0 fix so anybody who's on any version greater than 2.8 can try out the changes and provide feedback.

@jankapunkt
Copy link
Member Author

@harryadel please try 1.0.0-beta.1

@harryadel
Copy link
Member

Will do, thanks!

@StorytellerCZ StorytellerCZ requested a review from harryadel April 8, 2024 15:54
Copy link
Member

@harryadel harryadel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes related to the versions number used but other than that, great work 👍

package.js Outdated Show resolved Hide resolved
package.js Outdated Show resolved Hide resolved
package.js Outdated Show resolved Hide resolved
test-proxy/package.json Show resolved Hide resolved
@jankapunkt
Copy link
Member Author

@harryadel @StorytellerCZ this is also fixed now. Please use the latest release 1.0.0-beta300.2 with your Meteor 3 apps and let me know if it works as expected.

@Sergeant61
Copy link

@harryadel @StorytellerCZ this is also fixed now. Please use the latest release 1.0.0-beta300.2 with your Meteor 3 apps and let me know if it works as expected.

Hello, I am using it in a meteor package I just wrote in meteor 3.0 and it works fine. fyi.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants