perf: reduce GC pressure by avoiding EJSON.clone #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alisnic
changed the title
|
LGTM, but we need to get the tests going first. 😞 |
|
@StorytellerCZ they fail because redis oplog source has class static functions which are not supported by bundlers in old Meteor versions I assume. will try to remove 1.x from test matrix and see how 2.x tests run can you approve workflow or maybe somehow make it so I can test changes to CI without waiting for workflow approval? |
|
@StorytellerCZ I fixed the CI. Problem was that we need to use chai version 4.x, newer versions have dependencies with static class syntax. |
|
ping @StorytellerCZ |
|
Let's see if we can run the tests on the branch. |
StorytellerCZ
merged commit f77fe3e
into
Meteor-Community-Packages:master
16 checks passed
|
Will merge upstream and release shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After some loading testing efforts in our production app, we spotted in our memory profiles that EJSON.clone was one of the biggest sources of heap allocations. We started experimenting with removing some of them and see whether something breaks.
The change I submitted was tested on a e2e suite with 800+ tests and 3000+ unit tests and we didn't spot any issues so far.
I cannot say I fully understand the implications of these changes, but from what I've seen LocalCollection from meteor core does a bunch of clones on modifications anyway, so redis-oplog does not need to clone stuff when issuing callbacks.