Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input: Fix default text not being set when input doesnt immediately get focus #388

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

a-usr
Copy link

@a-usr a-usr commented Oct 30, 2024

Basically, I had this issue where I had a Layout consisting of 3 Inputs, all of which had default texts. However only the last Input (The one that received focus) Would set its own default text. That was an issue for me. So I fixed it.

Potential issues

  • I havent tested this with prompts much

@a-usr
Copy link
Author

a-usr commented Oct 30, 2024

image
funky

@MunifTanjim
Copy link
Owner

Yeah, GitHub actions is not showing the whole output. You can run it locally using ./scripts/test.sh. One of the tests for input is failing.

@a-usr
Copy link
Author

a-usr commented Oct 30, 2024

I have my doubts
image

@a-usr
Copy link
Author

a-usr commented Oct 30, 2024

Might be something with my environment. However even then I kind of doubt that Github actions truncated the output

@MunifTanjim
Copy link
Owner

Hmmm... weird. I'll look into it.

image

I haven't tried out the PR yet. Will do that as soon as possible.

@a-usr
Copy link
Author

a-usr commented Oct 30, 2024

Thats some very weird behaviour, considering the changes I made shouldnt really affect this test.
It seems like somehow there is a nil value or empty string for the first element in one of the tables? I am really confused as to how it gets there...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants