Inexactness and some tests #376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #376 +/- ##
==========================================
+ Coverage 73.95% 74.07% +0.12%
==========================================
Files 271 273 +2
Lines 22456 22806 +350
==========================================
+ Hits 16607 16894 +287
- Misses 5849 5912 +63
☔ View full report in Codecov by Sentry. |
|
Would it make sense to test this with IMEX, too? |
|
What exactly are you referring to? The interpolation between restarts actually is not implemented with IMEX, if I remember correctly. The extrapolation inside the collocation problem is something we can test in IMEX. We would have to add an IMEX version of the polynomial test problem. But then again, this feature is not too important. |
pancetta
reviewed
Nov 9, 2023
| if type(lvl.f[0]) == imex_mesh: | ||
| f = [me.impl + me.expl for me in lvl.f] | ||
| f = [lvl.f[i].impl + lvl.f[i].expl if self.coeff.f[i] and lvl.f[i] else 0.0 for i in range(len(lvl.f) - 1)] |
There was a problem hiding this comment.
I guess this is what I'm referring to
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes slight changes to the Newton inexactness convergence controller to make it a bit more general as well as the option for linear inexactness in Allen-Cahn and Quench.
Also, the test for the extrapolation error estimate within the collocation method is refined to be closer to a unit test than an integration test.
Efficient sweepers allow to save a few operations when computing the residual only on the last rank.