Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to ruff #475

Merged
merged 13 commits into from
Sep 3, 2024
Merged

Conversation

jakob-fritz
Copy link
Collaborator

As Flakeheaven does not support python 3.12, the idea was to migrate to ruff.

Most of the config was reused, but some rules differ. Therefore, some rules were added (See line 90ff in pyproject.toml) and some small changes in the code have been done to satisfy the new linter. The changes in the codes are grouped per commit; all changes with the same error are in the same commit.

The statistic (lines of code, number of paths, ...) are not available in ruff.

Closes #473

@jakob-fritz jakob-fritz added the girl scout rule All you did was leave the campground slightly cleaner than you found it. label Sep 3, 2024
@jakob-fritz jakob-fritz self-assigned this Sep 3, 2024
Copy link
Member

@pancetta pancetta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very much appreciated, thanks!

Copy link
Contributor

@brownbaerchen brownbaerchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! LGMT

@jakob-fritz jakob-fritz merged commit 3b0576b into Parallel-in-Time:master Sep 3, 2024
89 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
girl scout rule All you did was leave the campground slightly cleaner than you found it.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate from Flakeheaven to ruff
3 participants