-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to ruff #475
Merged
jakob-fritz
merged 13 commits into
Parallel-in-Time:master
from
jakob-fritz:migrate_to_ruff
Sep 3, 2024
Merged
Migrate to ruff #475
jakob-fritz
merged 13 commits into
Parallel-in-Time:master
from
jakob-fritz:migrate_to_ruff
Sep 3, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakob-fritz
added
the
girl scout rule
All you did was leave the campground slightly cleaner than you found it.
label
Sep 3, 2024
pancetta
approved these changes
Sep 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very much appreciated, thanks!
brownbaerchen
approved these changes
Sep 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot! LGMT
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As Flakeheaven does not support python 3.12, the idea was to migrate to ruff.
Most of the config was reused, but some rules differ. Therefore, some rules were added (See line 90ff in
pyproject.toml
) and some small changes in the code have been done to satisfy the new linter. The changes in the codes are grouped per commit; all changes with the same error are in the same commit.The statistic (lines of code, number of paths, ...) are not available in ruff.
Closes #473