Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changes done in header and footer ...issue #1962 resolved👍👍 #1963

Closed
wants to merge 1 commit into from

Conversation

MimanshaKaur
Copy link

Related Issue

None

Fixes: #(issue no.) #1962

Description

basically there are 4 changes/ fixations that i have done on about page...

  • i adjusted the margin space for logo so that it stays inside the header only...

  • added top margin in the first section(about buddy trail section) so that the heading is now not sticked with the header....hennce, some space is now added there...

  • the footer attached in this page is now properly aligned, and proper styling has been done

  • as you can see on the About page, the spacing of the section(The Buddy Trail Team section) just above the footer is now ok....Now , there is no overlapping as i adjusted the column's padding...

i have fixed the issue number: #1962

Type of PR

  • [ x] Bug fix

Screenshots / videos (if applicable)

Before :

Screenshot 2024-11-09 032507

Screenshot 2024-11-09 032333

Screenshot 2024-11-09 031620
changes:

after :

Screenshot 2024-11-09 042122
Screenshot 2024-11-09 042107
Screenshot 2024-11-09 042058

Checklist:

  • [x ] I have made this change from my own.
  • [ x] My code follows the style guidelines of this project.
  • [ x] I have performed a self-review of my own code.
  • [ x] I have made corresponding changes to the documentation.
  • [x ] My changes generate no new warnings.
  • [ x] I have tested the changes thoroughly before submitting this pull request.
  • [ x] I have provided relevant issue numbers and screenshots after making the changes.

Copy link

vercel bot commented Nov 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
buddy-trail ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 8, 2024 10:59pm

Copy link
Contributor

github-actions bot commented Nov 8, 2024

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our contributing.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

Copy link

netlify bot commented Nov 8, 2024

Deploy Preview for buddytrail ready!

Name Link
🔨 Latest commit cec6b21
🔍 Latest deploy log https://app.netlify.com/sites/buddytrail/deploys/672e97aee93188000883234a
😎 Deploy Preview https://deploy-preview-1963--buddytrail.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@MimanshaKaur
Copy link
Author

@PriyaGhosal please approve this PR mam........
Thank you for this chance to make me work on this project

@PriyaGhosal
Copy link
Owner

Please see the conflicts . Resolve the conflicts . Ensure you pull all the latest changes before pushing your feature/bug fixes to the main branch. After resolving the conflicts, please open a new PR for review.
Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants