Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Classes Public For Extra Loaders Through Plugins #466

Closed

Conversation

coolGi69
Copy link
Contributor

@coolGi69 coolGi69 commented Jan 7, 2025

This PR just makes some classes public to allow for loader plugins to be created.
While both classes that are now made public aren't necessary to be to make a plugin, it makes it slightly easier.

@AlexIIL
Copy link
Contributor

AlexIIL commented Jan 7, 2025

You should be able to make plugin icons via QuiltLoaderGui.createIcon(*)? (You're explicitly not meant to create String path icons yourself since they only read from loader's jar file).

Similarly, would you be okay if we added public api factory methods for ModDependencyImpl (in ModDependency) instead of making the classes public?

@coolGi69
Copy link
Contributor Author

coolGi69 commented Jan 7, 2025

You should be able to make plugin icons via QuiltLoaderGui.createIcon(*)? (You're explicitly not meant to create String path icons yourself since they only read from loader's jar file).

Ah, alright. Missed that part when looking through the code when attempting to make the plugin.

Similarly, would you be okay if we added public api factory methods for ModDependencyImpl (in ModDependency) instead of making the classes public?

Yeah, sure. That's fine, I was just thinking to reduce code duplication this could be public.
I guess it's fine to implement it myself.

@coolGi69 coolGi69 closed this Jan 7, 2025
@coolGi69 coolGi69 deleted the extra-loaders-using-plugins branch January 7, 2025 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants