This repository has been archived by the owner on May 1, 2024. It is now read-only.
forked from validatedpatterns/multicluster-devsecops
-
Notifications
You must be signed in to change notification settings - Fork 2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com>
Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com>
Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com>
Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com>
Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com>
Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com>
Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com>
Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com>
Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com>
Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com>
Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com>
Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com>
Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com>
Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com>
Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com>
Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com>
Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com>
Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com>
Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com>
Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com>
Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com>
Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com>
Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com>
Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com>
Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com>
Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com>
Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com>
Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com>
Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com>
Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com>
Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com>
Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com>
Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com>
Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com>
Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com>
Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com>
Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com>
Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com>
Signed-off-by: Tomer Figenblat <tfigenbl@redhat.com>
chore: pattern touchups
Signed-off-by: Tomer Figenblat <tfigenbl@redhat.com>
chore: pattern touchups
Signed-off-by: Tomer Figenblat <tfigenbl@redhat.com>
chore: removed unused manifest
Rdr tuning
Signed-off-by: Tomer Figenblat <tfigenbl@redhat.com>
Signed-off-by: Tomer Figenblat <tfigenbl@redhat.com>
…t the RegionalDR Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com>
Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com>
TomerFi
suggested changes
Apr 3, 2024
@@ -122,7 +122,7 @@ by [ACM][acm]'s heartbeat mechanism, a failover will be triggered to all related | |||
|
|||
## Further Reading | |||
|
|||
- [Deploy an example DR Application][example-app] | |||
- [Deploy an example DR Application](./rdr-example-app/README.md) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@r2dedios We don't need both example apps. We should delete the old busybox one while PRing the new pacman one. Also, the previous example app folder structure was:
The new example app diverged from this structure and was placed in the project's root. Should we adapt to the previous structure to be consistent with the rest of the pattern documentation? |
For the failing markdown lint, you can run this locally to work through the errors: podman run --privileged \
-e RUN_LOCAL=true \
-e DEFAULT_BRANCH=main \
-e VALIDATE_MARKDOWN=true \
-e VALIDATE_NATURAL_LANGUAGE=true \
-v $PWD:/tmp/lint \
ghcr.io/super-linter/super-linter:latest |
PR wrong created |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Included Doc and Manifests for deploying a test application for checking the RegionalDR