Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

RegionalDR example application #7

Closed
wants to merge 107 commits into from

Conversation

r2dedios
Copy link

@r2dedios r2dedios commented Apr 1, 2024

Included Doc and Manifests for deploying a test application for checking the RegionalDR

Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com>
Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com>
Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com>
Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com>
Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com>
Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com>
Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com>
Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com>
Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com>
Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com>
Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com>
Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com>
Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com>
Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com>
Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com>
Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com>
Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com>
Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com>
Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com>
Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com>
Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com>
Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com>
Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com>
Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com>
Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com>
Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com>
Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com>
Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com>
Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com>
r2dedios and others added 20 commits March 14, 2024 12:53
Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com>
Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com>
Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com>
Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com>
Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com>
Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com>
Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com>
Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com>
Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com>
Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com>
Signed-off-by: Tomer Figenblat <tfigenbl@redhat.com>
Signed-off-by: Tomer Figenblat <tfigenbl@redhat.com>
Signed-off-by: Tomer Figenblat <tfigenbl@redhat.com>
chore: removed unused manifest
Signed-off-by: Tomer Figenblat <tfigenbl@redhat.com>
Signed-off-by: Tomer Figenblat <tfigenbl@redhat.com>
…t the RegionalDR

Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com>
@r2dedios r2dedios added the enhancement New feature or request label Apr 1, 2024
@r2dedios r2dedios self-assigned this Apr 1, 2024
Signed-off-by: Alejandro Villegas <alex.ansi.c@gmail.com>
@r2dedios r2dedios requested a review from TomerFi April 1, 2024 15:04
@@ -122,7 +122,7 @@ by [ACM][acm]'s heartbeat mechanism, a failover will be triggered to all related

## Further Reading

- [Deploy an example DR Application][example-app]
- [Deploy an example DR Application](./rdr-example-app/README.md)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert this to [example-app] and scroll down to the end of the README; there, you will find the link that needs to be modified.

image

@TomerFi
Copy link
Member

TomerFi commented Apr 3, 2024

@r2dedios We don't need both example apps. We should delete the old busybox one while PRing the new pacman one.

Also, the previous example app folder structure was:

The new example app diverged from this structure and was placed in the project's root. Should we adapt to the previous structure to be consistent with the rest of the pattern documentation?

@TomerFi
Copy link
Member

TomerFi commented Apr 3, 2024

For the failing markdown lint, you can run this locally to work through the errors:

podman run --privileged \
  -e RUN_LOCAL=true \
  -e DEFAULT_BRANCH=main \
  -e VALIDATE_MARKDOWN=true  \
  -e VALIDATE_NATURAL_LANGUAGE=true  \
  -v $PWD:/tmp/lint \
  ghcr.io/super-linter/super-linter:latest

@TomerFi
Copy link
Member

TomerFi commented Apr 3, 2024

@r2dedios I just noticed you created this PR from the branch pattern-final-fixes, which was already merged here: #5. (That explains 107 commits...).
image

You should refresh your fork, create a new branch from the main one, and only include commits relevant to this PR.

@r2dedios
Copy link
Author

PR wrong created

@r2dedios r2dedios closed this Apr 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants