Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update INDEX.html #134

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

akshitbansal2005
Copy link

  1. Reusability & Readability:

    • The password toggle functionality is now modular, improving code reuse.
    • The notification display logic is encapsulated in a function, reducing redundancy.
  2. Validation Improvements:

    • The email validation is more flexible, allowing any valid domain instead of just gmail.com.
    • Password strength validation is streamlined with specific conditions (length, case, numbers, special characters) and offers visual feedback through a strength indicator.
  3. Form Interaction:

    • Both sign-in and sign-up forms have clear validation logic, and the flow is more user-friendly, using notifications for errors or success.
  4. Password Strength Indicator:

    • Provides a more dynamic user experience, adjusting colors and messages based on password complexity.
  5. Modal Handling:

    • The forgot password modal logic is improved for smoother interactions, including closing behavior and email validation for sending reset links.

What does this PR do?

(Provide a description of what this PR does.)

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work.)

Related PRs and Issues

(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)

Have you read the Contributing Guidelines on issues?

(Write your answer here.)

1. **Reusability & Readability:**
   - The password toggle functionality is now modular, improving code reuse.
   - The notification display logic is encapsulated in a function, reducing redundancy.

2. **Validation Improvements:**
   - The email validation is more flexible, allowing any valid domain instead of just `gmail.com`.
   - Password strength validation is streamlined with specific conditions (length, case, numbers, special characters) and offers visual feedback through a strength indicator.

3. **Form Interaction:**
   - Both sign-in and sign-up forms have clear validation logic, and the flow is more user-friendly, using notifications for errors or success.
   
4. **Password Strength Indicator:**
   - Provides a more dynamic user experience, adjusting colors and messages based on password complexity.

5. **Modal Handling:**
   - The forgot password modal logic is improved for smoother interactions, including closing behavior and email validation for sending reset links.
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Thank you @akshitbansal2005 for your contribution! Your pull request has been submitted successfully. A maintainer will review it as soon as possible. We appreciate your support in making this project better

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant