Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix brigandyne_2e_edition.html #13505

Merged
merged 1 commit into from
Nov 26, 2024
Merged

Conversation

CuracaoGold
Copy link
Contributor

Submission Checklist

Required

  • [x ] The pull request title clearly contains the name of the sheet I am editing.
  • [x ] The pull request title clearly states the type of change I am submitting (New Sheet/New Feature/Bugfix/etc.).
  • [x ] The pull request makes changes to files in only one sub-folder.
  • [x ] The pull request does not contain changes to any json files in the translations folder (translation.json is permitted)

New Sheet Details

  • The name of this game is: < > (i.e. Dungeons & Dragons 5th Edition, The Dresden Files RPG)

  • The publisher of this game is: < > (i.e. Wizards of the Coast, Evil Hat)

  • The name of this game system/family is: < > (i.e. Dungeons & Dragons, FATE)

  • I have followed the Character Sheets Standards when building this sheet.

  • I have authorization from the game's publisher to make this an official sheet on Roll20 with their name attached.
  • This game is not a traditionally published game, but a copy of the game rules can be purchased/downloaded/found at: < >
  • This sheet is for an unofficial fan game, modification to an existing game, or a homebrew system.

Changes / Description

Correcting a typo to enhance the display of the spells repeating list

@CuracaoGold CuracaoGold requested a review from a team as a code owner November 11, 2024 20:13
@kfroll20
Copy link
Contributor

Hello @CuracaoGold,

I wanted to let you know that we are taking a look at why the check is failing. Once we get that resolved, we will merge this as soon as possible to ensure the build succeeds and the sheet is updated.

@CuracaoGold
Copy link
Contributor Author

Hello @CuracaoGold,

I wanted to let you know that we are taking a look at why the check is failing. Once we get that resolved, we will merge this as soon as possible to ensure the build succeeds and the sheet is updated.

Hello kf, any update since last week message ?
Kind regards

@kfroll20
Copy link
Contributor

Hello @CuracaoGold,
I wanted to let you know that we are taking a look at why the check is failing. Once we get that resolved, we will merge this as soon as possible to ensure the build succeeds and the sheet is updated.

Hello kf, any update since last week message ? Kind regards

Hello @CuracaoGold! I am sorry for the delay in getting this merged. The team finished work on a more descriptive and reliable replacement validator to allow for us to better understand why the checks fail. Once this gets implemented and we can pinpoint the cause of the failing check, we will get this merged as soon as possible. We appreciate your patience with this.

Thank you for your understanding,
Kayla

@kfroll20
Copy link
Contributor

@CuracaoGold, we are going to attempt to merge this now since the change you made is so small. If it still doesn't build, we will continue to dig deeper into why the build breaks and keep working on the new validator as it will be a lot more reliable and informative. Thank you again for your patience and understanding as we make improvements to the workflow!

@kfroll20 kfroll20 merged commit b36b616 into Roll20:master Nov 26, 2024
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants