Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draci doupe II – token markers for "load" attribute #13512

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

nesuprachy
Copy link
Contributor

Submission Checklist

Required

  • The pull request title clearly contains the name of the sheet I am editing.
  • The pull request title clearly states the type of change I am submitting (New Sheet/New Feature/Bugfix/etc.).
  • The pull request makes changes to files in only one sub-folder.
  • The pull request does not contain changes to any json files in the translations folder (translation.json is permitted)

New Sheet Details

  • The name of this game is: < > (i.e. Dungeons & Dragons 5th Edition, The Dresden Files RPG)

  • The publisher of this game is: < > (i.e. Wizards of the Coast, Evil Hat)

  • The name of this game system/family is: < > (i.e. Dungeons & Dragons, FATE)

  • I have followed the Character Sheets Standards when building this sheet.

  • I have authorization from the game's publisher to make this an official sheet on Roll20 with their name attached.
  • This game is not a traditionally published game, but a copy of the game rules can be purchased/downloaded/found at: < >
  • This sheet is for an unofficial fan game, modification to an existing game, or a homebrew system.

Changes / Description

  • Added token icons for "load" attribute

@NorWhal
Copy link
Contributor

NorWhal commented Nov 21, 2024

Hey @nesuprachy,
We're not sure what could be throwing an error in our validator here, but we just finished work on a more descriptive replacement validator. We're going to work on implementing that replacement in the coming days and run it on your update once it's ready.

@NorWhal NorWhal closed this Nov 22, 2024
@NorWhal NorWhal reopened this Nov 22, 2024
@NorWhal
Copy link
Contributor

NorWhal commented Dec 5, 2024

Thanks for the wait on this, @nesuprachy! There's a bit of work that still needs to be done on the validator that we won't expect you to wait any longer for. There's still no explanation we can give to the error, but a manual inspection gives us fairly high confidence that nothing will break if we approve this. Please keep an eye out and let us know if there's anything wrong!

Thanks,
Nora

@NorWhal NorWhal merged commit dd2d7a4 into Roll20:master Dec 5, 2024
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants