Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forbidden Lands v1.9 #13541

Merged
merged 53 commits into from
Nov 26, 2024
Merged

Forbidden Lands v1.9 #13541

merged 53 commits into from
Nov 26, 2024

Conversation

vince-roll20
Copy link
Contributor

    - Push your rolls without the API! The sheet's rolls have been updated with CRP(custom roll parsing). You can now roll your dice pool and push them directly from the chat window without having to manually adjust the pool and re-rolling. (thank you Richard for letting me mangle your MYZ CRP code for this.)
    - Consumable rolls will now auto-decrement the resource's die size on failed rolls.
    - The roll template now displays the dice pool results horizontally.

Submission Checklist

Required

  • The pull request title clearly contains the name of the sheet I am editing.
  • The pull request title clearly states the type of change I am submitting (New Sheet/New Feature/Bugfix/etc.).
  • The pull request makes changes to files in only one sub-folder.
  • The pull request does not contain changes to any json files in the translations folder (translation.json is permitted)

New Sheet Details

  • The name of this game is: < > (i.e. Dungeons & Dragons 5th Edition, The Dresden Files RPG)

  • The publisher of this game is: < > (i.e. Wizards of the Coast, Evil Hat)

  • The name of this game system/family is: < > (i.e. Dungeons & Dragons, FATE)

  • I have followed the Character Sheets Standards when building this sheet.

  • I have authorization from the game's publisher to make this an official sheet on Roll20 with their name attached.
  • This game is not a traditionally published game, but a copy of the game rules can be purchased/downloaded/found at: < >
  • This sheet is for an unofficial fan game, modification to an existing game, or a homebrew system.

Changes / Description

- moved artifact dice to footer
- eslint wants commas in js
- dice pool flag added to push macro
…es failures and gearfails to show in the roll tmeplate

- BUG: artifact d12 is showing 1 success on a 10 instead of 3.
…perated cases.

- updated the push option to be removed if success+failures is greater than or equal to total dice. Solves bug for artifact dice always displaying the push option.
- planning to use crp roll to auto-reduce failed consumable rolls
- artificat die bane footer note is jacked on consumable rolls.  Need to isolate conumable rolls and remove display:inline-flex on those dice
- need to remove the macro-text sheetworker for consumables.  No longer needed.
@roll20deploy
Copy link
Contributor

Character Sheet Info Roll20 Internal Use only.

@NorWhal NorWhal merged commit c41fb3a into Roll20:master Nov 26, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants