Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StargateSG-1 - Bugfix #13588

Merged
merged 1 commit into from
Dec 12, 2024
Merged

StargateSG-1 - Bugfix #13588

merged 1 commit into from
Dec 12, 2024

Conversation

Hexenstag
Copy link
Contributor

Submission Checklist

Required

  • The pull request title clearly contains the name of the sheet I am editing.
  • The pull request title clearly states the type of change I am submitting (New Sheet/New Feature/Bugfix/etc.).
  • The pull request makes changes to files in only one sub-folder.
  • The pull request does not contain changes to any json files in the translations folder (translation.json is permitted)

Changes / Description

-Fix Balance, Climb, Open Lock, and Xeno-Languages skills, not rolling because of bad values.

@roll20deploy
Copy link
Contributor

Character Sheet Info Roll20 Internal Use only.

@kfroll20
Copy link
Contributor

Hello @Hexenstag!

Thank you for contributing to the community repo! When changing name attributes, please ensure that sheet workers are implemented to handle the name change and transfer existing data. This will prevent any data loss for existing players. Once you've made this update, we can get this merged for you.

Thank you!

@Hexenstag
Copy link
Contributor Author

@kfroll20 I apologize for my ignorance as I'm not familiar with HTML, I'm only trying to update these sheets so they are usable, as the skills in question do not function currently, but if I understand correctly these changes will not break any existing characters now.

-Fix Balance, Climb, Open Lock, and Xeno-Languages skills, not rolling because of bad values.
@kfroll20 kfroll20 merged commit 9885085 into Roll20:master Dec 12, 2024
1 check passed
@Hexenstag Hexenstag deleted the patch-1 branch December 16, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants