Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RolemasterUnified Official: Pre-Treasure Law Fixes #13594

Merged
merged 2 commits into from
Dec 10, 2024

Conversation

nashidau
Copy link
Contributor

@nashidau nashidau commented Dec 10, 2024

  • Finalise handling of Professions with selectable Base lists
    • Alchemists are the first users
  • Half shield bonus skill for partial block - not the full one (all my players)
  • Change 'maneuver_penalty' -> status_penalty
    • Update everywhere except inventory; it was a collision of names before.
  • Try and squash the super long list of errors when you first update stateud
  • Compendium data: Move a long bow to Bow, Long for the table. (@nef)
  • Equipment:
    • Perception Penalties are now applied
    • Ranged Penalties are now applied.
  • Take a terrible guess if it's a ranged or melee weapon when adding attacks
  • Creatures: Creatures can now roll skills.
  • Creatures: Add hx for Hand Crossbows, and a few other attacks (@nef)
  • Creatures now have framework for type of attack (melee, ranged, directed)
    • Does not (yet) change attack
    • Add test to validate attack types
  • Fix status effect typo (@kfroll20)

Submission Checklist

Required

  • The pull request title clearly contains the name of the sheet I am editing.
  • The pull request title clearly states the type of change I am submitting (New Sheet/New Feature/Bugfix/etc.).
  • The pull request makes changes to files in only one sub-folder.
  • The pull request does not contain changes to any json files in the translations folder (translation.json is permitted)

New Sheet Details

  • The name of this game is: < > (i.e. Dungeons & Dragons 5th Edition, The Dresden Files RPG)

  • The publisher of this game is: < > (i.e. Wizards of the Coast, Evil Hat)

  • The name of this game system/family is: < > (i.e. Dungeons & Dragons, FATE)

  • I have followed the Character Sheets Standards when building this sheet.

  • I have authorization from the game's publisher to make this an official sheet on Roll20 with their name attached.
  • This game is not a traditionally published game, but a copy of the game rules can be purchased/downloaded/found at: < >
  • This sheet is for an unofficial fan game, modification to an existing game, or a homebrew system.

Changes / Description

- Finalise handling of Professions with selectable Base lists
    - Alchemists are the first users
- Half shield bonus skill for partial block - not the full one (all my
  players)
- Change 'maneuver_penalty' -> status_penalty
  - Update everywhere except inventory; it was a collision of names before.
- Try and squash the super long list of errors when you first update stateud
- Compendium data: Move a long bow to Bow, Long for the table. (@nef)
- Equipment:
  - Perception Penalties are now applied
  - Ranged Penalties are now applied.
- Take a terrible guess if it's a ranged or melee weapon when adding attacks
- Creatures: Creatures can now roll skills.
- Creatures: Add hx for Hand Crossbows, and a few other attacks (@nef)
- Creatures now have framework for type of attack (melee, ranged, directed)
  - Does not (yet) change attack
  - Add test to validate attack types
@nashidau nashidau requested a review from a team as a code owner December 10, 2024 07:20
@roll20deploy
Copy link
Contributor

Character Sheet Info Roll20 Internal Use only.

@@ -13193,7 +13270,7 @@ <h3>Custom Spell List</h3>
`{\{target=${cdata.targetname}}} ` +
`{\{targetescaped=${cdata.targetescaped}}} ` +
`{\{weapon=${cdata.attackname}}} ` +
`{\{maneuverpenalty=${cdata.maneuver_penalty}}} ` +
`{\{statuspenalty=${cdata.statu_penalty}}} ` +
Copy link
Contributor

@kfroll20 kfroll20 Dec 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo? I think you want cdata.status_penalty

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are 100% correct.
Updated patch

@kfroll20 kfroll20 merged commit 463cb98 into Roll20:master Dec 10, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants