-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added dependency upgrades for python3.12 support #1951
Conversation
Pull Requestfixes #1926 DescriptionUpgraded most of the dependencies to support python3.12 version Changes MadeUpgraded the dependencies and the python docker images Checklist
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shivakrishnaah many thanks for your great contribution to add support for python 3.12.
To keep the changes for this PR as minimal as possible, lets just add support for python 3.12 and keep the default version of mlserver at python 3.10 for now. We cannot upgrade everything to python 3.12 at the moment as this will break other workflows that we have.
So lets revert the changes to the CI / dockerfile.
I have triggered the CI anyway so that we can look at the tests status.
@shivakrishnaah Many thanks for your recent changes. There are some issues with the CI (check here as an example):
The first thing that needs to be fixed perhaps on your PR is to run There are a few things to note:
note: I did push a few commits for reference, I hope this is fine with you. |
@sakoush Thank you for taking the time to review my PR. I have pulled the changes from your branch and merged them with mine. Please let me know if there's anything else I need to resolve or review. |
…shivakrishnaah/master
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for the initial work @shivakrishnaah I have done some extra work to get it over the line in the last few days.
Some of the CI tasks still fail which I will investigate before merging.
failing tests are all isolated in |
This PR adds support for python 3.11 and 3.12 to mlserver.
As
alibi-explain
andalibi-detect
runtimes required to be also upgraded to allow this support (and not yet released), we currently point to the master branches instead for installation.Before a proper release of mlserver, we need to revert this change. This also required a proper release of the Alibi libraries.
The main changes were on TensorFlow and Pytorch upgrades to support this transition.
Also the CI now contains tests for python 3.9-3.12 which we officially support.