Upgrade sample to React Native 76 #132
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markmur
force-pushed
the
markmur/react-native-76-support
branch
from
6e1aa89 to
cbde3ac
Compare
markmur
force-pushed
the
markmur/react-native-76-support
branch
from
46a943e to
1bcab6a
Compare
markmur
changed the title
markmur
commented
Oct 25, 2024
Comment on lines
-73
to
-81
| "eslintConfig": { | ||
| "root": true, | ||
| "extends": "@react-native", | ||
| "rules": { | ||
| "@typescript-eslint/no-shadow": "off", | ||
| "@typescript-eslint/consistent-type-imports": "error", | ||
| "no-console": "error" | ||
| } | ||
| }, |
There was a problem hiding this comment.
Moved to it's own file so it's easier to configure rules for sample + module
markmur
force-pushed
the
markmur/react-native-76-support
branch
from
1bcab6a to
f74ca80
Compare
markmur
changed the title
markmur
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are you making?
Note that this increases the minimum deployment target for the sample app to iOS 15.1.
See https://react-native-community.github.io/upgrade-helper/?from=0.74.1&to=0.76.0&package=com.reactnative&name=ReactNative for diff between versions.
This PR is mostly implementing the diffs
PR Checklist
Important