Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump ruby 3.1.2 -> 3.3.6 #151

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

kieran-osgood-shopify
Copy link
Contributor

What changes are you making?

What
Bump .ruby-version up to the latest LTS version (3.1.2 -> 3.3.6)

Why
dev up fails for users without ruby 3.1.2 already on their system, due to a dependency on openssl@1.1 which homebrew disabled in October

Pertinent parts of dev up output in this case:

┏━━ 🔧  4/10 Ruby ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
┃ 𝒾 install ruby 3.1.2
┃ running brew update
==> Updating Homebrew...
┃ We need to install 1 package(s): openssl@1.1
┃ INSTALL packages: openssl@1.1
┏━━ Running `/opt/homebrew/bin/brew install openssl@1.1` ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
┃    Error: openssl@1.1 has been disabled because it is not supported upstream! It was disabled on 2024-10-24.
┃
┣━━ /opt/homebrew/bin/brew install openssl@1.1 failed ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
┃ A Homebrew command failed to complete. This could mean an issue with Homebrew or your system. In this case, we could not automatically troubleshoot the result. Please read the output for more info and Google the error. You can also try running brew doctor to debug Homebrew issues.
┗━━ /opt/homebrew/bin/brew install openssl@1.1 Failed! ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ (0.67s) ━━
┃ Error: openssl@1.1 has been disabled because it is not supported upstream! It was disabled on 2024-10-24.
┃
┃ 𝒾 Installing ruby 3.1.2 from binary tarball
┃┏━━ Ruby Binary Download ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
┃┃ Downloading Ruby from https://storage.googleapis.com/shopify-dev-public/dev-ruby-binaries/darwin-arm64/ruby-3.1.2-2ee1127775837a3b4294203e4e72ee9ea6e8484a2967154300ce04f46d34b9c6.tgz
┃┃ It has an expected sha of 2ee1127775837a3b4294203e4e72ee9ea6e8484a2967154300ce04f46d34b9c6
┃┃                                                                                                                                                                                                                                                                                                                       100%
┃┗━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
┗━━ 💥  Failed! Aborting! ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ (7.29s) ━━
Ruby is linked against missing libraries:
/opt/homebrew/opt/openssl@1.1/lib/libssl.1.1.dylib
/opt/homebrew/opt/openssl@1.1/lib/libcrypto.1.1.dylib

How to test

You can confirm the same behaviour if you were to install latest LTS as your system version and remove 3.1.2
It's difficult to confirm how to uninstall as I can't get it installed in the first place, so just confirming it still works for existing users should be sufficient


PR Checklist

Important


Checklist for releasing a new version

Tip

See the Contributing documentation for instructions on how to publish a new version of the library.

@kieran-osgood-shopify kieran-osgood-shopify requested a review from a team as a code owner December 19, 2024 10:47
@kieran-osgood-shopify kieran-osgood-shopify changed the title chore: bump ruby 3.1.2 -> 3.3.6 bump ruby 3.1.2 -> 3.3.6 Dec 19, 2024
Copy link
Contributor

@markmur markmur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 Thanks for updating. You will just have to update your Github config to verify the commits and rebase

@kieran-osgood-shopify kieran-osgood-shopify force-pushed the kieran-osgood/bump-ruby-version branch from 7273b8e to 0f9e5d0 Compare January 16, 2025 11:05
@kieran-osgood-shopify kieran-osgood-shopify force-pushed the kieran-osgood/bump-ruby-version branch from 0f9e5d0 to c82c0db Compare January 16, 2025 11:06
@kieran-osgood-shopify kieran-osgood-shopify merged commit 2d01d5f into main Jan 16, 2025
8 checks passed
@kieran-osgood-shopify kieran-osgood-shopify deleted the kieran-osgood/bump-ruby-version branch January 16, 2025 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants