Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add expo config plugin to handle Android Webview title #80

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

xseignard
Copy link

@xseignard xseignard commented Apr 17, 2024

What changes are you making?

Add expo config plugin to be able to change android webview title in a managed expo project.

How to test


PR Checklist

Important


Checklist for releasing a new version

Tip

See the Contributing documentation for instructions on how to publish a new version of the library.

@xseignard xseignard requested a review from a team as a code owner April 17, 2024 06:05
@xseignard
Copy link
Author

I have signed the CLA!

@markmur
Copy link
Contributor

markmur commented Apr 19, 2024

Hey @xseignard, thanks for the PR. We are discussing internally whether we want to explicitly add support for managed workflows in Expo.

👀

@markmur
Copy link
Contributor

markmur commented Apr 19, 2024

@xseignard have you given any thought to how this might work cross-locale?

@xseignard
Copy link
Author

Hello @markmur,

Good call, I updated the plugin to handle this

@xseignard
Copy link
Author

Any updates here?

@xseignard
Copy link
Author

Can we reasonably expect feedback here?

@moimael
Copy link
Contributor

moimael commented Oct 15, 2024

Hey @markmur ! Did you end up aligning on a decision with the team? Is there anything we can help with to move this forward?

Thanks a ton!

@markmur
Copy link
Contributor

markmur commented Oct 16, 2024

Hey folks, apologies for the delay here. The team have been swamped.

Ideally we don't want to introduce Expo specific configs or plugins here if possible. Is it not possible to introduce android/app/src/main/res/values XML files in your Expo app?

@markmur
Copy link
Contributor

markmur commented Oct 16, 2024

Having discussed with the team, we are okay with shipping this in the short-term with an aim to remove it later by solving in a more generic way.

@xseignard would you mind rebasing your PR against latest main?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants