-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add expo config plugin to handle Android Webview title #80
base: main
Are you sure you want to change the base?
Conversation
I have signed the CLA! |
Hey @xseignard, thanks for the PR. We are discussing internally whether we want to explicitly add support for managed workflows in Expo. 👀 |
@xseignard have you given any thought to how this might work cross-locale? |
Hello @markmur, Good call, I updated the plugin to handle this |
Any updates here? |
Can we reasonably expect feedback here? |
Hey @markmur ! Did you end up aligning on a decision with the team? Is there anything we can help with to move this forward? Thanks a ton! |
Hey folks, apologies for the delay here. The team have been swamped. Ideally we don't want to introduce Expo specific configs or plugins here if possible. Is it not possible to introduce |
Having discussed with the team, we are okay with shipping this in the short-term with an aim to remove it later by solving in a more generic way. @xseignard would you mind rebasing your PR against latest main? |
What changes are you making?
Add expo config plugin to be able to change android webview title in a managed expo project.
How to test
PR Checklist
Important
Checklist for releasing a new version
package.json
file.Tip
See the Contributing documentation for instructions on how to publish a new version of the library.