Only process retry queue on manual retries #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
casperisfine
approved these changes
Mar 26, 2024
zarifmahfuz
approved these changes
Mar 26, 2024
stephsachrajda
approved these changes
Mar 26, 2024
ChrisBr
force-pushed
the
cbruckmayer/only-process-retry-queue-on-manual-retries
branch
3 times, most recently
from
6350571 to
98610e4
Compare
ChrisBr
force-pushed
the
cbruckmayer/only-process-retry-queue-on-manual-retries
branch
from
98610e4 to
9e68d5d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We sometimes have the case that a lot of tests fail in a job and e.g. cause it to OOM or timeout. In this case, jobs often get automatically retried and then process the exact same tests again. We should only process the retry queue on a manual retry. Automatic job retries should join the main queue instead.