Skip to content

Commit

Permalink
Set override flag when moving downloaded binary
Browse files Browse the repository at this point in the history
  • Loading branch information
jeffcharles committed Dec 3, 2024
1 parent e643396 commit 4b93d76
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
5 changes: 5 additions & 0 deletions .changeset/khaki-glasses-wave.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@shopify/app': patch
---

Fix error when downloading Javy plugin in parallel
2 changes: 1 addition & 1 deletion packages/app/src/cli/services/function/binaries.ts
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ export async function downloadBinary(bin: DownloadableBinary) {
const outputStream = createFileWriteStream(tmpFile)
await bin.processResponse(responseStream, outputStream)
await chmod(tmpFile, 0o775)
await moveFile(tmpFile, bin.path)
await moveFile(tmpFile, bin.path, {overwrite: true})
})
},
async () => {},
Expand Down

0 comments on commit 4b93d76

Please sign in to comment.