Merge pull request #5048 from Shopify/gg-fix-empty-file-upload

Allow empty theme files to be uploaded
Shopify · Dec 6, 2024 · 8cd1218 · 8cd1218
2 parents 7835a90 + 94953a6
commit 8cd1218
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 8 deletions.
diff --git a/.changeset/honest-cobras-invite.md b/.changeset/honest-cobras-invite.md
@@ -0,0 +1,5 @@
+---
+'@shopify/cli-kit': patch
+---
+
+Fix bug preventing empty theme files from uploading
diff --git a/packages/cli-kit/src/public/node/themes/api.ts b/packages/cli-kit/src/public/node/themes/api.ts
@@ -119,24 +119,22 @@ export async function bulkUploadThemeAssets(
 
 function prepareFilesForUpload(assets: AssetParams[]): OnlineStoreThemeFilesUpsertFileInput[] {
   return assets.map((asset) => {
-    if (asset.value) {
+    if (asset.attachment) {
       return {
         filename: asset.key,
         body: {
-          type: 'TEXT' as const,
-          value: asset.value,
+          type: 'BASE64' as const,
+          value: asset.attachment,
         },
       }
-    } else if (asset.attachment) {
+    } else {
       return {
         filename: asset.key,
         body: {
-          type: 'BASE64' as const,
-          value: asset.attachment,
+          type: 'TEXT' as const,
+          value: asset.value ?? '',
         },
       }
-    } else {
-      unexpectedGraphQLError('Asset must have a value or attachment')
     }
   })
 }