Merge pull request #5015 from Shopify/gg-fix-empty-file-upload

Allow empty theme files to be uploaded

.changeset/honest-cobras-invite.md

@@ -0,0 +1,5 @@
+---
+'@shopify/cli-kit': patch
+---
+
+Fix bug preventing empty theme files from uploading

.github/CODEOWNERS

@@ -3,7 +3,7 @@
 
 # Theme team and CLI owners should review theme changes
 packages/cli-kit/src/private/themes/* @shopify/advanced-edits @shopify/app-inner-loop
-packages/cli-kit/src/public/themes/* @shopify/advanced-edits @shopify/app-inner-loop
+packages/cli-kit/src/public/**/themes/* @shopify/advanced-edits @shopify/app-inner-loop
 packages/theme/** @shopify/advanced-edits @shopify/app-inner-loop
 
 # These are metafiles that can be reviewed by anyone

packages/cli-kit/src/public/node/themes/api.ts

@@ -119,24 +119,22 @@ export async function bulkUploadThemeAssets(
 
 function prepareFilesForUpload(assets: AssetParams[]): OnlineStoreThemeFilesUpsertFileInput[] {
   return assets.map((asset) => {
-    if (asset.value) {
+    if (asset.attachment) {
       return {
         filename: asset.key,
         body: {
-          type: 'TEXT' as const,
-          value: asset.value,
+          type: 'BASE64' as const,
+          value: asset.attachment,
         },
       }
-    } else if (asset.attachment) {
+    } else {
       return {
         filename: asset.key,
         body: {
-          type: 'BASE64' as const,
-          value: asset.attachment,
+          type: 'TEXT' as const,
+          value: asset.value ?? '',
         },
       }
-    } else {
-      unexpectedGraphQLError('Asset must have a value or attachment')
     }
   })
 }