Fix shopify theme pull --only <value>
so it does not delete ignored files
#4563
+26
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fixes #4472
WHAT is this pull request doing?
This updates the
shopify theme pull
command to ignore files as expected by applying the ignore filters in the local keys.How to test your changes?
shopify theme init test
cd test
rm locales/es*
shopify theme push -d
git checkout locales/
shopify theme pull -d --only config
locales/es.json
andlocales/es.schema.json
are no longer deletedPost-release steps
N/A
Measuring impact
How do we know this change was effective? Please choose one:
Checklist