Migrate localization validations to Core #5165
Open
+5
−56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
Coverage report
Show files with reduced coverage 🔻
Test suite run success2000 tests passing in 904 suites. Report generated by 🧪jest coverage report action from f80ea94 |
cameronbarker
force-pushed
the
remove-localization-file-limits
branch
from
eb1175a to
19173f7
Compare
cameronbarker
changed the title
amcaplan
approved these changes
Jan 12, 2025
isaacroldan
approved these changes
Jan 13, 2025
graygilmore
reviewed
Jan 16, 2025
| // Locale validations | ||
| for (const locale of localesPaths) { | ||
| const size = fs.statSync(locale).size | ||
| if (size > L10N_FILE_SIZE_LIMIT) | ||
| throw new AbortError( |
There was a problem hiding this comment.
Will users continue to see a validation error if it's too big? Essentially we're just moving the validation from pre to post-upload attempt?
There was a problem hiding this comment.
Yes exactly, users will still see the validation, but now they will be coming the post-upload system.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See for context on why we are removing this: https://github.com/Shopify/shopify/pull/566161#issue-2780703768
Checklist