Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename bundle to bundle-for-release #5187

Merged
merged 1 commit into from
Jan 14, 2025
Merged

Rename bundle to bundle-for-release #5187

merged 1 commit into from
Jan 14, 2025

Conversation

isaacroldan
Copy link
Contributor

@isaacroldan isaacroldan commented Jan 13, 2025

WHY are these changes introduced?

To prevent people from running pnpm bundle locally, which might break their CLI dev environment.

WHAT is this pull request doing?

Renames the bundle script to bundle-for-release in package.json and updates all shipit configuration files to use the new script name. This change makes it more explicit that this bundling step is specifically for the release process and should not be used locally.

How to test your changes?

  1. Run pnpm bundle-for-release to verify the renamed script works as expected
  2. Verify that the nightly/snapshot build process completes successfully

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@isaacroldan isaacroldan marked this pull request as ready for review January 13, 2025 14:54
@isaacroldan isaacroldan requested a review from a team as a code owner January 13, 2025 14:54
@isaacroldan isaacroldan changed the title Rename bundle to bundle-for-release: Rename bundle to bundle-for-release Jan 13, 2025
Copy link
Contributor

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
75.18% (+0% 🔼)
8883/11816
🟡 Branches
70.36% (+0.03% 🔼)
4317/6136
🟡 Functions
75.1% (+0.01% 🔼)
2322/3092
🟡 Lines
75.75% (+0.01% 🔼)
8398/11087
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟡
... / context.ts
70.75% (-0.54% 🔻)
62.07% (+0.4% 🔼)
73.91%
73.33% (-0.58% 🔻)
🟢
... / app-event-watcher.ts
93.83% (-1.23% 🔻)
86.49% (-2.7% 🔻)
90.48% 98.61%
🔴
... / app-management-client.ts
29.52% (-0.26% 🔻)
16.83% 31.25%
28.4% (-0.29% 🔻)
🔴
... / partners-client.ts
26.28% (-0.53% 🔻)
37.5% 17.86%
25.76% (-0.56% 🔻)

Test suite run success

2006 tests passing in 904 suites.

Report generated by 🧪jest coverage report action from 564c391

@isaacroldan isaacroldan added this pull request to the merge queue Jan 14, 2025
Merged via the queue into main with commit 271e28c Jan 14, 2025
27 checks passed
@isaacroldan isaacroldan deleted the rename-bundle-script branch January 14, 2025 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants