Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI extension sourcemaps]: Only generate with --sourcemaps option #5190

Closed
wants to merge 2 commits into from

Conversation

jamesvidler
Copy link
Contributor

@jamesvidler jamesvidler commented Jan 13, 2025

WHY are these changes introduced?

Generating sourcemaps for UI extensions is only useful for partners who wish to use these, and this likely won't be common. Rather than generate these for all UI extensions, allow partners to opt into the behavior.

WHAT is this pull request doing?

This adds --sourcemaps flag to the existing build and deploy commands.

How to test your changes?

Post-release steps

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes

@jamesvidler
Copy link
Contributor Author

Closing this PR since the addition of a --sourcemaps flag would not be appropriate since it only applies to ui extensions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant