Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update CLI app not found error message #5193

Merged
merged 1 commit into from
Jan 15, 2025
Merged

update CLI app not found error message #5193

merged 1 commit into from
Jan 15, 2025
+129 −32

Conversation

alexanderMontague
Copy link
Contributor

@alexanderMontague alexanderMontague commented Jan 14, 2025 •
edited
Loading

WHY are these changes introduced?

closes: https://github.com/Shopify/develop-app-inner-loop/issues/2460

WHAT is this pull request doing?

image.png

co-authored by @Kenneth-Ye

  • updates the app not found message to be a bit more specific as well as provide some helpful next steps
  • we predict this scenario may be more common with the swapping between dev dash / partners contexts

How to test your changes?

  • create an app via partners or management API
  • then try to run any app command against that app using the other API to see the new error banner

Post-release steps

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes

@alexanderMontague alexanderMontague requested a review from a team as a code owner January 14, 2025 20:25
@github-actions GitHub Actions
Copy link
Contributor

We detected some changes at packages/*/src and there are no updates in the .changeset.
If the changes are user-facing, run "pnpm changeset add" to track your changes and include them in the next release CHANGELOG.

@alexanderMontague Graphite App
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 14, 2025 •
edited
Loading

Coverage report

St.❔
 Category Percentage Covered / Total
🟡 Statements
75.11% (-0.01% 🔻)
 8883/11827
🟡 Branches
70.15% (-0.12% 🔻)
 4334/6178
🟡 Functions
75.01% (-0.03% 🔻)
 2323/3097
🟡 Lines
75.66% (-0.01% 🔻)
 8398/11100
Show files with reduced coverage 🔻
St.❔
 File Statements Branches Functions Lines
🟢
... / app-event-watcher.ts
93.83% (-1.23% 🔻)
86.49% (-2.7% 🔻)
 90.48% 98.61%
🔴
... / app-management-client.ts
29.78% (-3.68% 🔻)
16.83% (-9.38% 🔻)
31.25% (-2.77% 🔻)
28.69% (-3.99% 🔻)
🟢
... / ConcurrentOutput.tsx
98.36% (-1.64% 🔻)
88% (-4% 🔻)
 100%
98.33% (-1.67% 🔻)

Test suite run success

2005 tests passing in 905 suites.

Report generated by 🧪jest coverage report action from 5156a87

@alexanderMontague @Kenneth-Ye
closes: Shopify/develop-app-inner-loop#2460
5156a87 
- Updates the CLI banner message to include better next steps when an app could not be found

Co-authored-by: Kenneth Ye <kenneth.ye@shopify.com>
@alexanderMontague alexanderMontague force-pushed the 01-14-closes_https__github.com_shopify_develop-app-inner-loop_issues_2460 branch from 5cf2d8a to 5156a87 Compare January 14, 2025 20:32
dmerand
dmerand approved these changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@dmerand dmerand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tophat LGTM!

jenstanicak
jenstanicak approved these changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@jenstanicak jenstanicak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

content LGTM!

@alexanderMontague alexanderMontague added this pull request to the merge queue Jan 15, 2025
Merged via the queue into main with commit 14612d3 Jan 15, 2025
28 checks passed
@alexanderMontague alexanderMontague deleted the 01-14-closes_https__github.com_shopify_develop-app-inner-loop_issues_2460 branch January 15, 2025 14:28
@alexanderMontague alexanderMontague changed the title closes: https://github.com/Shopify/develop-app-inner-loop/issues/2460 update CLI app not found error message Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jenstanicak jenstanicak jenstanicak approved these changes

@dmerand dmerand dmerand approved these changes

@isaacroldan isaacroldan Awaiting requested review from isaacroldan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexanderMontague @dmerand @jenstanicak