Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support local dev in CLI #5199

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

shauns
Copy link
Contributor

@shauns shauns commented Jan 15, 2025

No description provided.

@shauns shauns marked this pull request as ready for review January 15, 2025 12:45
@shauns shauns requested a review from a team as a code owner January 15, 2025 12:45
Copy link
Contributor Author

shauns commented Jan 15, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link
Contributor

We detected some changes at packages/*/src and there are no updates in the .changeset.
If the changes are user-facing, run "pnpm changeset add" to track your changes and include them in the next release CHANGELOG.

Copy link
Contributor

Differences in type declarations

We detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:

  • Some seemingly private modules might be re-exported through public modules.
  • If the branch is behind main you might see odd diffs, rebase main into this branch.

New type declarations

We found no new type declarations in this PR

Existing type declarations

packages/cli-kit/dist/private/node/constants.d.ts
@@ -32,6 +32,7 @@ export declare const environmentVariables: {
     themeKitAccessDomain: string;
     json: string;
     useAppManagement: string;
+    neverUsePartnersApi: string;
 };
 export declare const defaultThemeKitAccessDomain = "theme-kit-access.shopifyapps.com";
 export declare const systemEnvironmentVariables: {
packages/cli-kit/dist/public/node/environment.d.ts
@@ -49,4 +49,10 @@ export declare function getIdentityTokenInformation(): {
  * @param environment - Process environment variables.
  * @returns True if the JSON output is enabled, false otherwise.
  */
-export declare function jsonOutputEnabled(environment?: NodeJS.ProcessEnv): boolean;
\ No newline at end of file
+export declare function jsonOutputEnabled(environment?: NodeJS.ProcessEnv): boolean;
+/**
+ * If true, the CLI should not use the Partners API.
+ *
+ * @returns True if the SHOPIFY_CLI_NEVER_USE_PARTNERS_API environment variable is set.
+ */
+export declare function blockPartnersAccess(): boolean;
\ No newline at end of file

@shauns shauns marked this pull request as draft January 15, 2025 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant