Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.73] Fix shopify theme dev to no longer fail when development the… #5202

Merged
merged 2 commits into from
Jan 16, 2025

Conversation

karreiro
Copy link
Contributor

Back-port #5200

@karreiro karreiro requested review from a team as code owners January 15, 2025 15:56
@karreiro karreiro requested a review from EvilGenius13 January 15, 2025 15:56
Copy link
Contributor

github-actions bot commented Jan 15, 2025

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 75.36% 8847/11740
🟡 Branches 70.59% 4292/6080
🟡 Functions 75.24% 2316/3078
🟡 Lines 75.91% 8364/11019

Test suite run success

1998 tests passing in 903 suites.

Report generated by 🧪jest coverage report action from 59feaa7

Copy link
Contributor

Differences in type declarations

We detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:

  • Some seemingly private modules might be re-exported through public modules.
  • If the branch is behind main you might see odd diffs, rebase main into this branch.

New type declarations

We found no new type declarations in this PR

Existing type declarations

packages/cli-kit/dist/private/node/session.d.ts
@@ -1,3 +1,4 @@
+/// <reference types="node" resolution-mode="require"/>
 import { AdminSession } from '@shopify/cli-kit/node/session';
 /**
  * A scope supported by the Shopify Admin API.
packages/cli-kit/dist/private/node/ui.d.ts
@@ -1,3 +1,5 @@
+/// <reference types="react" />
+/// <reference types="node" resolution-mode="require"/>
 import { Logger, LogLevel } from '../../public/node/output.js';
 import { Key, RenderOptions } from 'ink';
 import { EventEmitter } from 'events';
packages/cli-kit/dist/public/common/version.d.ts
@@ -1 +1 @@
-export declare const CLI_KIT_VERSION = "3.73.0";
\ No newline at end of file
+export declare const CLI_KIT_VERSION = "3.73.1";
\ No newline at end of file
packages/cli-kit/dist/public/node/cli.d.ts
@@ -1,3 +1,4 @@
+/// <reference types="node" resolution-mode="require"/>
 /**
  * IMPORTANT NOTE: Imports in this module are dynamic to ensure that "setupEnvironmentVariables" can dynamically
  * set the DEBUG environment variable before the 'debug' package sets up its configuration when modules
packages/cli-kit/dist/public/node/crypto.d.ts
@@ -1,3 +1,4 @@
+/// <reference types="node" resolution-mode="require"/>
 /**
  * Generate a random string in Hex format of the provided size.
  *
packages/cli-kit/dist/public/node/environment.d.ts
@@ -1,3 +1,4 @@
+/// <reference types="node" resolution-mode="require"/>
 /**
  * It returns the environment variables of the environment
  * where the Node process is running.
packages/cli-kit/dist/public/node/fs.d.ts
@@ -1,3 +1,5 @@
+/// <reference types="node" resolution-mode="require"/>
+/// <reference types="node" resolution-mode="require"/>
 import { RandomNameFamily } from '../common/string.js';
 import { OverloadParameters } from '../../private/common/ts/overloaded-parameters.js';
 import { findUp as internalFindUp } from 'find-up';
packages/cli-kit/dist/public/node/monorail.d.ts
@@ -16,7 +16,6 @@ export interface Schemas {
             env_plugin_installed_all?: Optional<string>;
         };
         public: {
-            business_platform_id?: Optional<number>;
             partner_id?: Optional<number>;
             command: string;
             project_type?: Optional<string>;
packages/cli-kit/dist/public/node/node-package-manager.d.ts
@@ -1,3 +1,5 @@
+/// <reference types="node" resolution-mode="require"/>
+/// <reference types="node" resolution-mode="require"/>
 import { AbortError, BugError } from './error.js';
 import { AbortSignal } from './abort.js';
 import type { Writable } from 'stream';
packages/cli-kit/dist/public/node/notifications-system.d.ts
@@ -1,3 +1,4 @@
+/// <reference types="node" resolution-mode="require"/>
 import { zod } from './schema.js';
 declare const NotificationSchema: zod.ZodObject<{
     id: zod.ZodString;
@@ -28,11 +29,11 @@ declare const NotificationSchema: zod.ZodObject<{
     message: string;
     frequency: "always" | "once" | "once_a_day" | "once_a_week";
     ownerChannel: string;
-    title?: string | undefined;
     cta?: {
         url: string;
         label: string;
     } | undefined;
+    title?: string | undefined;
     minVersion?: string | undefined;
     maxVersion?: string | undefined;
     minDate?: string | undefined;
@@ -45,11 +46,11 @@ declare const NotificationSchema: zod.ZodObject<{
     message: string;
     frequency: "always" | "once" | "once_a_day" | "once_a_week";
     ownerChannel: string;
-    title?: string | undefined;
     cta?: {
         url: string;
         label: string;
     } | undefined;
+    title?: string | undefined;
     minVersion?: string | undefined;
     maxVersion?: string | undefined;
     minDate?: string | undefined;
@@ -88,11 +89,11 @@ declare const NotificationsSchema: zod.ZodObject<{
         message: string;
         frequency: "always" | "once" | "once_a_day" | "once_a_week";
         ownerChannel: string;
-        title?: string | undefined;
         cta?: {
             url: string;
             label: string;
         } | undefined;
+        title?: string | undefined;
         minVersion?: string | undefined;
         maxVersion?: string | undefined;
         minDate?: string | undefined;
@@ -105,11 +106,11 @@ declare const NotificationsSchema: zod.ZodObject<{
         message: string;
         frequency: "always" | "once" | "once_a_day" | "once_a_week";
         ownerChannel: string;
-        title?: string | undefined;
         cta?: {
             url: string;
             label: string;
         } | undefined;
+        title?: string | undefined;
         minVersion?: string | undefined;
         maxVersion?: string | undefined;
         minDate?: string | undefined;
@@ -124,11 +125,11 @@ declare const NotificationsSchema: zod.ZodObject<{
         message: string;
         frequency: "always" | "once" | "once_a_day" | "once_a_week";
         ownerChannel: string;
-        title?: string | undefined;
         cta?: {
             url: string;
             label: string;
         } | undefined;
+        title?: string | undefined;
         minVersion?: string | undefined;
         maxVersion?: string | undefined;
         minDate?: string | undefined;
@@ -143,11 +144,11 @@ declare const NotificationsSchema: zod.ZodObject<{
         message: string;
         frequency: "always" | "once" | "once_a_day" | "once_a_week";
         ownerChannel: string;
-        title?: string | undefined;
         cta?: {
             url: string;
             label: string;
         } | undefined;
+        title?: string | undefined;
         minVersion?: string | undefined;
         maxVersion?: string | undefined;
         minDate?: string | undefined;
@@ -166,25 +167,11 @@ export type Notifications = zod.infer<typeof NotificationsSchema>;
  */
 export declare function showNotificationsIfNeeded(currentSurfaces?: string[], environment?: NodeJS.ProcessEnv): Promise<void>;
 /**
- * Get notifications list from cache, that is updated in the background from bin/fetch-notifications.json.
+ * Get notifications list from cache (refreshed every hour) or fetch it if not present.
  *
  * @returns A Notifications object.
  */
 export declare function getNotifications(): Promise<Notifications>;
-/**
- * Fetch notifications from the CDN and chache them.
- *
- * @returns A string with the notifications.
- */
-export declare function fetchNotifications(): Promise<Notifications>;
-/**
- * Fetch notifications in background as a detached process.
- *
- * @param currentCommand - The current Shopify command being run.
- * @param argv - The arguments passed to the current process.
- * @param environment - Process environment variables.
- */
-export declare function fetchNotificationsInBackground(currentCommand: string, argv?: string[], environment?: NodeJS.ProcessEnv): void;
 /**
  * Filters notifications based on the version of the CLI.
  *
packages/cli-kit/dist/public/node/output.d.ts
@@ -1,3 +1,5 @@
+/// <reference types="node" resolution-mode="require"/>
+/// <reference types="node" resolution-mode="require"/>
 import { PackageManager } from './node-package-manager.js';
 import { AbortSignal } from './abort.js';
 import { TokenItem } from './ui.js';
packages/cli-kit/dist/public/node/path.d.ts
+/// <reference types="node" resolution-mode="require"/>
 import type { URL } from 'url';
 /**
  * Joins a list of paths together.
  *
  * @param paths - Paths to join.
  * @returns Joined path.
  */
 export declare function joinPath(...paths: string[]): string;
 /**
  * Normalizes a path.
  *
  * @param path - Path to normalize.
  * @returns Normalized path.
  */
 export declare function normalizePath(path: string): string;
 /**
  * Resolves a list of paths together.
  *
  * @param paths - Paths to resolve.
  * @returns Resolved path.
  */
 export declare function resolvePath(...paths: string[]): string;
 /**
  * Returns the relative path from one path to another.
  *
  * @param from - Path to resolve from.
  * @param to - Path to resolve to.
  * @returns Relative path.
  */
 export declare function relativePath(from: string, to: string): string;
 /**
  * Returns whether the path is absolute.
  *
  * @param path - Path to check.
  * @returns Whether the path is absolute.
  */
 export declare function isAbsolutePath(path: string): boolean;
 /**
  * Returns the directory name of a path.
  *
  * @param path - Path to get the directory name of.
  * @returns Directory name.
  */
 export declare function dirname(path: string): string;
 /**
  * Returns the base name of a path.
  *
  * @param path - Path to get the base name of.
  * @param ext - Optional extension to remove from the result.
  * @returns Base name.
  */
 export declare function basename(path: string, ext?: string): string;
 /**
  * Returns the extension of the path.
  *
  * @param path - Path to get the extension of.
  * @returns Extension.
  */
 export declare function extname(path: string): string;
 /**
  * Given an absolute filesystem path, it makes it relative to
  * the current working directory. This is useful when logging paths
  * to allow the users to click on the file and let the OS open it
  * in the editor of choice.
  *
  * @param path - Path to relativize.
  * @param dir - Current working directory.
  * @returns Relativized path.
  */
 export declare function relativizePath(path: string, dir?: string): string;
 /**
  * Given 2 paths, it returns whether the second path is a subpath of the first path.
  *
  * @param mainPath - The main path.
  * @param subpath - The subpath.
  * @returns Whether the subpath is a subpath of the main path.
  */
 export declare function isSubpath(mainPath: string, subpath: string): boolean;
 /**
  * Given a module's import.meta.url it returns the directory containing the module.
  *
  * @param moduleURL - The value of import.meta.url in the context of the caller module.
  * @returns The path to the directory containing the caller module.
  */
 export declare function moduleDirectory(moduleURL: string | URL): string;
 /**
  * When running a script using `npm run`, something interesting happens. If the current
  * folder does not have a `package.json` or a `node_modules` folder, npm will traverse
  * the directory tree upwards until it finds one. Then it will run the script and set
  * `process.cwd()` to that folder, while the actual path is stored in the INIT_CWD
  * environment variable (see here: https://docs.npmjs.com/cli/v9/commands/npm-run-script#description).
  *
  * @returns The path to the current working directory.
  */
 export declare function cwd(): string;
 /**
  * Tries to get the value of the `--path` argument, if provided.
  *
  * @param argv - The arguments to search for the `--path` argument.
  * @returns The value of the `--path` argument, if provided.
  */
 export declare function sniffForPath(argv?: string[]): string | undefined;
 /**
  * Returns whether the `--json` or `-j` flags are present in the arguments.
  *
  * @param argv - The arguments to search for the `--json` and `-j` flags.
  * @returns Whether the `--json` or `-j` flag is present in the arguments.
  */
 export declare function sniffForJson(argv?: string[]): boolean;
packages/cli-kit/dist/public/node/plugins.d.ts
@@ -16,7 +16,7 @@ import { Config, Interfaces } from '@oclif/core';
  * @returns A dictionary of plug-in names to the response from the hook.
  */
 export declare function fanoutHooks<TPluginMap extends HookReturnsPerPlugin, TEvent extends string & keyof TPluginMap>(config: Interfaces.Config, event: TEvent, options: TPluginMap[typeof event]['options'], timeout?: number): Promise<Partial<TPluginMap[typeof event]['pluginReturns']>>;
-type AppSpecificMonorailFields = PickByPrefix<MonorailEventPublic, 'app_', 'project_type' | 'api_key' | 'partner_id' | 'business_platform_id'> & PickByPrefix<MonorailEventPublic, 'cmd_extensions_'> & PickByPrefix<MonorailEventPublic, 'cmd_scaffold_'>;
+type AppSpecificMonorailFields = PickByPrefix<MonorailEventPublic, 'app_', 'project_type' | 'api_key' | 'partner_id'> & PickByPrefix<MonorailEventPublic, 'cmd_extensions_'> & PickByPrefix<MonorailEventPublic, 'cmd_scaffold_'>;
 type AppSpecificSensitiveMonorailFields = PickByPrefix<MonorailEventSensitive, 'app_'>;
 export interface HookReturnsPerPlugin extends HookReturnPerTunnelPlugin {
     public_command_metadata: {
packages/cli-kit/dist/public/node/session.d.ts
@@ -1,3 +1,4 @@
+/// <reference types="node" resolution-mode="require"/>
 import { AdminAPIScope, AppManagementAPIScope, BusinessPlatformScope, PartnersAPIScope, StorefrontRendererScope } from '../../private/node/session.js';
 /**
  * Session Object to access the Admin API, includes the token and the store FQDN.
packages/cli-kit/dist/public/node/system.d.ts
@@ -1,3 +1,4 @@
+/// <reference types="node" resolution-mode="require"/>
 import { AbortSignal } from './abort.js';
 import type { Writable, Readable } from 'stream';
 export interface ExecOptions {
@@ -12,7 +13,6 @@ export interface ExecOptions {
     input?: string;
     signal?: AbortSignal;
     externalErrorHandler?: (error: unknown) => Promise<void>;
-    background?: boolean;
 }
 /**
  * Opens a URL in the user's default browser.
packages/cli-kit/dist/public/node/ui.d.ts
@@ -1,3 +1,4 @@
+/// <reference types="node" resolution-mode="require"/>
 import { FatalError as Fatal } from './error.js';
 import { Logger, LogLevel } from './output.js';
 import { ConcurrentOutputProps } from '../../private/node/ui/components/ConcurrentOutput.js';
packages/cli-kit/dist/private/node/api/headers.d.ts
@@ -1,3 +1,4 @@
+/// <reference types="node" resolution-mode="require"/>
 import { ExtendableError } from '../../../public/node/error.js';
 import https from 'https';
 export declare class RequestClientError extends ExtendableError {
packages/cli-kit/dist/private/node/context/service.d.ts
@@ -1,3 +1,4 @@
+/// <reference types="node" resolution-mode="require"/>
 /**
  * Enum that represents the environment to use for a given service.
  *
packages/cli-kit/dist/private/node/context/utilities.d.ts
@@ -1,3 +1,4 @@
+/// <reference types="node" resolution-mode="require"/>
 /**
  * Returns whether an environment variable has been set and is non-empty
  */
packages/cli-kit/dist/private/node/session/scopes.d.ts
@@ -1,3 +1,4 @@
+/// <reference types="node" resolution-mode="require"/>
 import { API } from '../api.js';
 /**
  * Generate a flat array with all the default scopes for all the APIs plus
packages/cli-kit/dist/private/node/testing/ui.d.ts
@@ -1,3 +1,4 @@
+/// <reference types="node" resolution-mode="require"/>
 import { Stdout } from '../ui.js';
 import { ReactElement } from 'react';
 import { EventEmitter } from 'events';
packages/cli-kit/dist/private/node/ui/utilities.d.ts
@@ -1,16 +1,2 @@
 import { TokenItem } from './components/TokenizedText.js';
-export declare function messageWithPunctuation(message: TokenItem): string | {
-    command: string;
-} | import("./components/TokenizedText.js").LinkToken | {
-    char: string;
-} | import("./components/TokenizedText.js").UserInputToken | {
-    subdued: string;
-} | {
-    filePath: string;
-} | import("./components/TokenizedText.js").ListToken | import("./components/TokenizedText.js").BoldToken | {
-    info: string;
-} | {
-    warn: string;
-} | {
-    error: string;
-} | import("./components/TokenizedText.js").Token[];
\ No newline at end of file
+export declare function messageWithPunctuation(message: TokenItem): string | import("./components/TokenizedText.js").CommandToken | import("./components/TokenizedText.js").LinkToken | import("./components/TokenizedText.js").CharToken | import("./components/TokenizedText.js").UserInputToken | import("./components/TokenizedText.js").SubduedToken | import("./components/TokenizedText.js").FilePathToken | import("./components/TokenizedText.js").ListToken | import("./components/TokenizedText.js").BoldToken | import("./components/TokenizedText.js").InfoToken | import("./components/TokenizedText.js").WarnToken | import("./components/TokenizedText.js").ErrorToken | import("./components/TokenizedText.js").Token[];
\ No newline at end of file
packages/cli-kit/dist/public/node/context/local.d.ts
@@ -1,3 +1,4 @@
+/// <reference types="node" resolution-mode="require"/>
 import { Metadata } from '../../../private/node/context/utilities.js';
 /**
  * It returns true if the terminal is interactive.
packages/cli-kit/dist/public/node/context/spin.d.ts
@@ -1,3 +1,4 @@
+/// <reference types="node" resolution-mode="require"/>
 /**
  * When ran in a Spin environment, it returns the fqdn of the instance.
  *
packages/cli-kit/dist/public/node/themes/api.d.ts
@@ -22,5 +22,4 @@ export declare function metafieldDefinitionsByOwnerType(type: MetafieldOwnerType
         name: string;
         category: string;
     };
-}[]>;
-export declare function passwordProtected(session: AdminSession): Promise<boolean>;
\ No newline at end of file
+}[]>;
\ No newline at end of file
packages/cli-kit/dist/public/node/themes/types.d.ts
@@ -1,3 +1,4 @@
+/// <reference types="node" resolution-mode="require"/>
 import { AdminSession } from '../session.js';
 /**
  * {@link Key} represents the unique identifier of a file in a theme.
packages/cli-kit/dist/private/node/ui/components/Alert.d.ts
@@ -1,10 +1,9 @@
 import { BannerType } from './Banner.js';
 import { BoldToken, InlineToken, LinkToken, TokenItem } from './TokenizedText.js';
-import { TabularDataProps } from './TabularData.js';
 import { FunctionComponent } from 'react';
 export interface CustomSection {
     title?: string;
-    body: TabularDataProps | TokenItem;
+    body: TokenItem;
 }
 export interface AlertProps {
     type: Exclude<BannerType, 'external_error'>;
packages/cli-kit/dist/private/node/ui/components/Tasks.d.ts
@@ -8,7 +8,7 @@ export interface Task<TContext = unknown> {
     errors?: Error[];
     skip?: (ctx: TContext) => boolean;
 }
-interface TasksProps<TContext> {
+export interface TasksProps<TContext> {
     tasks: Task<TContext>[];
     silent?: boolean;
     onComplete?: (ctx: TContext) => void;
packages/cli-kit/dist/private/node/ui/components/TokenizedText.d.ts
@@ -1,13 +1,25 @@
 import { FunctionComponent } from 'react';
+export interface CommandToken {
+    command: string;
+}
 export interface LinkToken {
     link: {
         label?: string;
         url: string;
     };
 }
+export interface CharToken {
+    char: string;
+}
 export interface UserInputToken {
     userInput: string;
 }
+export interface SubduedToken {
+    subdued: string;
+}
+export interface FilePathToken {
+    filePath: string;
+}
 export interface ListToken {
     list: {
         title?: TokenItem<InlineToken>;
@@ -18,21 +30,16 @@ export interface ListToken {
 export interface BoldToken {
     bold: string;
 }
-export type Token = string | {
-    command: string;
-} | LinkToken | {
-    char: string;
-} | UserInputToken | {
-    subdued: string;
-} | {
-    filePath: string;
-} | ListToken | BoldToken | {
+export interface InfoToken {
     info: string;
-} | {
+}
+export interface WarnToken {
     warn: string;
-} | {
+}
+export interface ErrorToken {
     error: string;
-};
+}
+export type Token = string | CommandToken | LinkToken | CharToken | UserInputToken | SubduedToken | FilePathToken | ListToken | BoldToken | InfoToken | WarnToken | ErrorToken;
 export type InlineToken = Exclude<Token, ListToken>;
 export type TokenItem<T extends Token = Token> = T | T[];
 export declare function tokenItemToString(token: TokenItem): string;
packages/cli-kit/dist/private/node/ui/hooks/use-layout.d.ts
@@ -1,3 +1,4 @@
+/// <reference types="node" resolution-mode="require"/>
 interface Layout {
     twoThirds: number;
     oneThird: number;
packages/cli-kit/dist/private/node/ui/hooks/use-prompt.d.ts
@@ -1,3 +1,4 @@
+/// <reference types="react" />
 export declare enum PromptState {
     Idle = "idle",
     Loading = "loading",
packages/cli-kit/dist/cli/api/graphql/admin/generated/get_theme.d.ts
@@ -11,4 +11,6 @@ export type GetThemeQuery = {
         processing: boolean;
     } | null;
 };
-export declare const GetTheme: DocumentNode<GetThemeQuery, GetThemeQueryVariables>;
\ No newline at end of file
+export declare const GetTheme: DocumentNode<GetThemeQuery, Types.Exact<{
+    id: Types.Scalars['ID']['input'];
+}>>;
\ No newline at end of file
packages/cli-kit/dist/cli/api/graphql/admin/generated/get_theme_file_bodies.d.ts
@@ -34,4 +34,8 @@ export type GetThemeFileBodiesQuery = {
         } | null;
     } | null;
 };
-export declare const GetThemeFileBodies: DocumentNode<GetThemeFileBodiesQuery, GetThemeFileBodiesQueryVariables>;
\ No newline at end of file
+export declare const GetThemeFileBodies: DocumentNode<GetThemeFileBodiesQuery, Types.Exact<{
+    id: Types.Scalars['ID']['input'];
+    after?: Types.InputMaybe<string> | undefined;
+    filenames?: Types.InputMaybe<string | string[]> | undefined;
+}>>;
\ No newline at end of file
packages/cli-kit/dist/cli/api/graphql/admin/generated/get_theme_file_checksums.d.ts
@@ -23,4 +23,7 @@ export type GetThemeFileChecksumsQuery = {
         } | null;
     } | null;
 };
-export declare const GetThemeFileChecksums: DocumentNode<GetThemeFileChecksumsQuery, GetThemeFileChecksumsQueryVariables>;
\ No newline at end of file
+export declare const GetThemeFileChecksums: DocumentNode<GetThemeFileChecksumsQuery, Types.Exact<{
+    id: Types.Scalars['ID']['input'];
+    after?: Types.InputMaybe<string> | undefined;
+}>>;
\ No newline at end of file
packages/cli-kit/dist/cli/api/graphql/admin/generated/get_themes.d.ts
@@ -17,4 +17,6 @@ export type GetThemesQuery = {
         };
     } | null;
 };
-export declare const GetThemes: DocumentNode<GetThemesQuery, GetThemesQueryVariables>;
\ No newline at end of file
+export declare const GetThemes: DocumentNode<GetThemesQuery, Types.Exact<{
+    after?: Types.InputMaybe<string> | undefined;
+}>>;
\ No newline at end of file
packages/cli-kit/dist/cli/api/graphql/admin/generated/metafield_definitions_by_owner_type.d.ts
@@ -17,4 +17,6 @@ export type MetafieldDefinitionsByOwnerTypeQuery = {
         }[];
     };
 };
-export declare const MetafieldDefinitionsByOwnerType: DocumentNode<MetafieldDefinitionsByOwnerTypeQuery, MetafieldDefinitionsByOwnerTypeQueryVariables>;
\ No newline at end of file
+export declare const MetafieldDefinitionsByOwnerType: DocumentNode<MetafieldDefinitionsByOwnerTypeQuery, Types.Exact<{
+    ownerType: Types.MetafieldOwnerType;
+}>>;
\ No newline at end of file
packages/cli-kit/dist/cli/api/graphql/admin/generated/public_api_versions.d.ts
@@ -9,4 +9,6 @@ export type PublicApiVersionsQuery = {
         supported: boolean;
     }[];
 };
-export declare const PublicApiVersions: DocumentNode<PublicApiVersionsQuery, PublicApiVersionsQueryVariables>;
\ No newline at end of file
+export declare const PublicApiVersions: DocumentNode<PublicApiVersionsQuery, Types.Exact<{
+    [key: string]: never;
+}>>;
\ No newline at end of file
packages/cli-kit/dist/cli/api/graphql/admin/generated/theme_delete.d.ts
@@ -12,4 +12,6 @@ export type ThemeDeleteMutation = {
         }[];
     } | null;
 };
-export declare const ThemeDelete: DocumentNode<ThemeDeleteMutation, ThemeDeleteMutationVariables>;
\ No newline at end of file
+export declare const ThemeDelete: DocumentNode<ThemeDeleteMutation, Types.Exact<{
+    id: Types.Scalars['ID']['input'];
+}>>;
\ No newline at end of file
packages/cli-kit/dist/cli/api/graphql/admin/generated/theme_files_upsert.d.ts
@@ -15,4 +15,7 @@ export type ThemeFilesUpsertMutation = {
         }[];
     } | null;
 };
-export declare const ThemeFilesUpsert: DocumentNode<ThemeFilesUpsertMutation, ThemeFilesUpsertMutationVariables>;
\ No newline at end of file
+export declare const ThemeFilesUpsert: DocumentNode<ThemeFilesUpsertMutation, Types.Exact<{
+    files: Types.OnlineStoreThemeFilesUpsertFileInput[] | Types.OnlineStoreThemeFilesUpsertFileInput;
+    themeId: Types.Scalars['ID']['input'];
+}>>;
\ No newline at end of file
packages/cli-kit/dist/cli/api/graphql/admin/generated/theme_publish.d.ts
@@ -16,4 +16,6 @@ export type ThemePublishMutation = {
         }[];
     } | null;
 };
-export declare const ThemePublish: DocumentNode<ThemePublishMutation, ThemePublishMutationVariables>;
\ No newline at end of file
+export declare const ThemePublish: DocumentNode<ThemePublishMutation, Types.Exact<{
+    id: Types.Scalars['ID']['input'];
+}>>;
\ No newline at end of file
packages/cli-kit/dist/cli/api/graphql/admin/generated/theme_update.d.ts
@@ -17,4 +17,7 @@ export type ThemeUpdateMutation = {
         }[];
     } | null;
 };
-export declare const ThemeUpdate: DocumentNode<ThemeUpdateMutation, ThemeUpdateMutationVariables>;
\ No newline at end of file
+export declare const ThemeUpdate: DocumentNode<ThemeUpdateMutation, Types.Exact<{
+    id: Types.Scalars['ID']['input'];
+    input: Types.OnlineStoreThemeInput;
+}>>;
\ No newline at end of file
packages/cli-kit/dist/private/node/ui/components/Table/Row.d.ts
@@ -1,3 +1,4 @@
+/// <reference types="react" />
 import ScalarDict from './ScalarDict.js';
 import { Column } from './Column.js';
 interface RowProps<T extends ScalarDict> {
packages/cli-kit/dist/private/node/ui/components/Table/Table.d.ts
@@ -1,3 +1,4 @@
+/// <reference types="react" />
 import ScalarDict from './ScalarDict.js';
 import { ForegroundColor } from 'chalk';
 export type TableColumn<T> = {

@karreiro karreiro merged commit 23bbb16 into stable/3.73 Jan 16, 2025
27 checks passed
@karreiro karreiro deleted the 3.73-fix-5192 branch January 16, 2025 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants