[Themes] Add debug logging for theme fetch errors #5203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage report
Show files with reduced coverage 🔻
Test suite run success2007 tests passing in 906 suites. Report generated by 🧪jest coverage report action from 25f9861 |
jamesmengo
added
the
Area: @shopify/theme
Graphite App
|
We detected some changes at packages/*/src and there are no updates in the .changeset. |
karreiro
approved these changes
Jan 15, 2025
There was a problem hiding this comment.
Thank you, @jamesmengo!
I had the same internal debate about this. My initial thought was that the command with the request ID would be enough to provide us some context. However, I don't think this line is harmful :)
EvilGenius13
approved these changes
Jan 15, 2025
jamesmengo
deleted the
jm/01-15-add_debug_log_to_fetchtheme_errorhandler
branch
jamesmengo
added a commit
that referenced
this pull request
Jan 15, 2025
…theme_errorhandler [Themes] Add debug logging for theme fetch errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Adds debug logging to report that themeFetch failed on top of the changes introduced in #5200
This is likely inconsequential, but may come in handy for debugging something in the future (even more so because the client will handle failures silently otherwise)
@karreiro Do we want to do this? Would we be adding too much noise?