Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix documentation: Download -> Push #5206

Merged
merged 2 commits into from
Jan 16, 2025
Merged

Fix documentation: Download -> Push #5206

merged 2 commits into from
Jan 16, 2025
+13 −8

Conversation

nicday
Copy link
Contributor

@nicday nicday commented Jan 15, 2025

Fixes documentation for theme push --only flag.

@nicday nicday requested review from a team as code owners January 15, 2025 20:49
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 15, 2025 •
edited
Loading

Coverage report

St.❔
 Category Percentage Covered / Total
🟡 Statements
75.11% (-0.07% 🔻)
 8878/11820
🟡 Branches
70.26% (-0.06% 🔻)
 4337/6173
🟡 Functions
75.04% (-0.02% 🔻)
 2324/3097
🟡 Lines
75.67% (-0.05% 🔻)
 8394/11093
Show files with reduced coverage 🔻
St.❔
 File Statements Branches Functions Lines
🟡
... / context.ts
71.3% (-7.52% 🔻)
61.67% (-4% 🔻)
73.91% (-5.25% 🔻)
73.91% (-7.46% 🔻)
🟢
... / app-event-watcher.ts
93.83% (-1.23% 🔻)
86.49% (-2.7% 🔻)
 90.48% 98.61%
🟢
... / Dev.tsx
93.1% (-0.96% 🔻)
77.78% (-1.91% 🔻)
90.91% (-1.09% 🔻)
93.9% (-0.78% 🔻)

Test suite run success

2005 tests passing in 905 suites.

Report generated by 🧪jest coverage report action from c68928d

@alexanderMontague @Kenneth-Ye
run graphql codegen
c68928d 
Co-authored-by: Kenneth Ye <kenneth.ye@shopify.com>
@nicday nicday added this pull request to the merge queue Jan 15, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 15, 2025
@nicday nicday added this pull request to the merge queue Jan 16, 2025
Merged via the queue into main with commit 06833b2 Jan 16, 2025
27 checks passed
@nicday nicday deleted the fix-docs branch January 16, 2025 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukeh-shopify lukeh-shopify lukeh-shopify approved these changes

@jamesmengo jamesmengo jamesmengo approved these changes

@alexanderMontague alexanderMontague alexanderMontague approved these changes

@graygilmore graygilmore graygilmore approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nicday @graygilmore @alexanderMontague @jamesmengo @lukeh-shopify