Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Themes] Trigger hot reload to update/render error overlay on asset upload error / fix #5211

Draft
wants to merge 1 commit into
base: jm/_Themes_Add_error_tracking_for_theme_upload_results
Choose a base branch
from

Conversation

jamesmengo
Copy link
Contributor

@jamesmengo jamesmengo commented Jan 16, 2025

WHY are these changes introduced?

Fixes #0000

WHAT is this pull request doing?

🎥 Video uploaded on Graphite:

How to test your changes?

Post-release steps

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes

Copy link
Contributor Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link
Contributor

Differences in type declarations

We detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:

  • Some seemingly private modules might be re-exported through public modules.
  • If the branch is behind main you might see odd diffs, rebase main into this branch.

New type declarations

We found no new type declarations in this PR

Existing type declarations

packages/cli-kit/dist/public/node/themes/types.d.ts
@@ -92,6 +92,10 @@ export interface ThemeFileSystem extends VirtualFileSystem {
     applyIgnoreFilters: <T extends {
         key: string;
     }>(files: T[]) => T[];
+    /**
+     * Stores upload errors returned when uploading files via the Asset API
+     */
+    uploadErrors: Map<Key, string[]>;
 }
 /**
  * Represents a theme on the file system.

Copy link
Contributor

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
75.17% (+0.01% 🔼)
8894/11832
🟡 Branches
70.3% (+0.02% 🔼)
4343/6178
🟡 Functions 75.06% 2326/3099
🟡 Lines
75.72% (+0.01% 🔼)
8409/11105

Test suite run success

2007 tests passing in 906 suites.

Report generated by 🧪jest coverage report action from cd2c906

@jamesmengo jamesmengo changed the title Trigger hot reload to update error overlay on asset upload error / fix [Themes]Trigger hot reload to update error overlay on asset upload error / fix Jan 16, 2025
@jamesmengo jamesmengo changed the title [Themes]Trigger hot reload to update error overlay on asset upload error / fix [Themes] Trigger hot reload to update error overlay on asset upload error / fix Jan 16, 2025
@jamesmengo jamesmengo changed the title [Themes] Trigger hot reload to update error overlay on asset upload error / fix [Themes] Trigger hot reload to update.rend error overlay on asset upload error / fix Jan 16, 2025
@jamesmengo jamesmengo changed the title [Themes] Trigger hot reload to update.rend error overlay on asset upload error / fix [Themes] Trigger hot reload to update/rend error overlay on asset upload error / fix Jan 16, 2025
@jamesmengo jamesmengo changed the title [Themes] Trigger hot reload to update/rend error overlay on asset upload error / fix [Themes] Trigger hot reload to update/render error overlay on asset upload error / fix Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant