Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify CreateAppOptions and DefaultAppOptions into a single object #5215

Open
wants to merge 2 commits into
base: 01-16-fix_dev_when_resetting_and_creating_a_new_app
Choose a base branch
from

Conversation

isaacroldan
Copy link
Contributor

@isaacroldan isaacroldan commented Jan 16, 2025

WHY are these changes introduced?

We had two very similar objects: CreateAppOptions and AppCreationDefaultOptions

We are refactoring and unifying everything to just use CreateAppOptions.

WHAT is this pull request doing?

  • Consolidates app creation options into a single CreateAppOptions interface
  • Removes redundant name parameter from createApp method signatures
  • Updates all callers to use the new unified options interface
  • Ensures directory is consistently passed through creation options

How to test your changes?

  1. Create a new app using shopify app init
  2. Link an existing app using shopify app config link
  3. Verify all app creation flows work as expected with proper options passed through

Measuring impact

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes

Copy link
Contributor Author

isaacroldan commented Jan 16, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@isaacroldan isaacroldan marked this pull request as ready for review January 16, 2025 15:52
@isaacroldan isaacroldan requested a review from a team as a code owner January 16, 2025 15:52
Copy link
Contributor

We detected some changes at packages/*/src and there are no updates in the .changeset.
If the changes are user-facing, run "pnpm changeset add" to track your changes and include them in the next release CHANGELOG.

Copy link
Contributor

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 75.18% 8906/11846
🟡 Branches
70.28% (-0.02% 🔻)
4347/6185
🟡 Functions 75.06% 2330/3104
🟡 Lines 75.73% 8418/11116
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / context.ts
78.63% (-0.18% 🔻)
65.67% 79.17%
81.19% (-0.18% 🔻)
🟢
... / app-event-watcher.ts
93.83%
83.78% (-2.7% 🔻)
90.48% 98.61%
🔴
... / app-management-client.ts
34.17% (+0.24% 🔼)
25.49% (-0.72% 🔻)
34.69%
33.2% (+0.26% 🔼)

Test suite run success

2008 tests passing in 906 suites.

Report generated by 🧪jest coverage report action from 8b53942

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant