Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit Gemfile.lock to Github #109

Merged
merged 1 commit into from
Sep 22, 2021
Merged

Commit Gemfile.lock to Github #109

merged 1 commit into from
Sep 22, 2021

Conversation

GustavoCaso
Copy link
Contributor

Related to #102

Commit Gemfile.lock following best practices https://bundler.io/blog/2018/01/17/making-gem-development-a-little-better.html

@Shopify/job-platform

@GustavoCaso GustavoCaso requested a review from Mangara September 21, 2021 11:18
@caution-tape-bot
Copy link

👋 It looks like you are introducing a version mismatch between sorbet and sorbet-runtime.

If that is the case please ensure the gem versions are consistent by modifying both sorbet and sorbet-runtime. If this is an automated bump please ensure both sorbet and sorbet-runtime bumps are merged in quick succession.

These 2 gems are tightly coupled and a difference in versions could cause type errors during production that is not visible with static checks. If you have any questions feel free to ping Shopify/sorbet or ask a question on Discourse. Take a look at the Dev Handbook for more information.

Copy link
Contributor

@Mangara Mangara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should make sure CI still runs against the latest version and not the version locked here.

@GustavoCaso GustavoCaso merged commit 4c99679 into master Sep 22, 2021
@GustavoCaso GustavoCaso deleted the commit-Gemfile-lock branch September 22, 2021 10:46
@shopify-shipit shopify-shipit bot temporarily deployed to rubygems September 24, 2021 13:20 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants