Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix supported Ruby and Rails versions #448

Merged
merged 1 commit into from
Jan 3, 2024
Merged

Fix supported Ruby and Rails versions #448

merged 1 commit into from
Jan 3, 2024

Conversation

angeloocana
Copy link
Contributor

@angeloocana angeloocana commented Jan 3, 2024 •
edited
Loading

Remove support for rails edge for Ruby 2.7 and 3.0 to fix failing CI tests.

Example PR with no real changes that is failing CI:
Screenshot 2024-01-03 at 11 59 39 AM

@angeloocana angeloocana marked this pull request as ready for review January 3, 2024 17:03
peterzhu2118
peterzhu2118 approved these changes Jan 3, 2024
View reviewed changes
Copy link
Member

@peterzhu2118 peterzhu2118 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we consider dropping support for Ruby 2.7? It's been EOL for almost a year.

Ruby 3.0 is going to be EOL in about 2 months from now. Should we also consider dropping support for that?

@angeloocana
Copy link
Contributor Author

Should we consider dropping support for Ruby 2.7? It's been EOL for almost a year.

Ruby 3.0 is going to be EOL in about 2 months from now. Should we also consider dropping support for that?

I agree @peterzhu2118 . Is there a team responsible for this repo? I'm putting this PR up just to unblock another WIP PR I'm working on.

@angeloocana
Copy link
Contributor Author

/shipit

@angeloocana angeloocana merged commit 44b95d2 into main Jan 3, 2024
35 checks passed
@sambostock sambostock deleted the fix-rails-ruby-version branch February 6, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterzhu2118 peterzhu2118 peterzhu2118 approved these changes

@sambostock sambostock Awaiting requested review from sambostock

@robsterner-shopify robsterner-shopify Awaiting requested review from robsterner-shopify

@Mangara Mangara Awaiting requested review from Mangara

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@angeloocana @peterzhu2118