Implement logic for stringify Hashes to keep compat with 3.4 #1892
+226
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianks
force-pushed
the
dpetrick/use_legacy_hash_format
branch
3 times, most recently
from
842f6ac to
8c89e6a
Compare
ggmichaelgo
approved these changes
Jan 15, 2025
| if seen[hash.object_id] | ||
| return "{...}" | ||
| end | ||
| seen[hash.object_id] = true |
There was a problem hiding this comment.
seen could be a Set if the values are always true
ianks
force-pushed
the
dpetrick/use_legacy_hash_format
branch
from
8c89e6a to
ffca018
Compare
ianks
force-pushed
the
dpetrick/use_legacy_hash_format
branch
from
9dba903 to
d02cf23
Compare
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ruby 3.4 changes to implementation of
Hash#to_sto be a more readable format. However, some Liquid templates rely on the legacy behavior, so we need to support the old format indefinitely.This PR makes it so Liquid is now responsible for stringify hashes instead of relying on Ruby.