Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add quintals and ton aliases #159

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

ragarwal6397
Copy link
Contributor

Add the quintal unit/aliases and also add two aliases for ton with the British spelling

@ragarwal6397
Copy link
Contributor Author

I have signed the CLA!

@kmcphillips
Copy link
Member

This makes sense. Love the UK spellings for tonne. Thanks for the test coverage.

CI is broken but that's about rails 8 beta and ruby versions. I'll have to look at that.

@kmcphillips
Copy link
Member

Do you want to rebase this over latest main now and we'll make sure it's green?

Add the quintal unit/aliases and also add two aliases for ton with the
British spelling
@ragarwal6397 ragarwal6397 force-pushed the add-quintals-and-t-aliases branch from 5951bc4 to 46f57bb Compare October 3, 2024 01:21
@ragarwal6397
Copy link
Contributor Author

Thanks @kmcphillips! Rebased on latest main

@kmcphillips kmcphillips merged commit 43fa51e into Shopify:main Oct 3, 2024
12 checks passed
@kmcphillips
Copy link
Member

Thank you for your contribution

@kmcphillips
Copy link
Member

Released in 3.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants