Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo TrianglesStrip -> TriangleStrip #2566

Merged
merged 6 commits into from
Aug 22, 2024

Conversation

mrEuler
Copy link
Contributor

@mrEuler mrEuler commented Aug 5, 2024

According to https://api.skia.org/classSkVertices.html#a7676d1d74f49cdf5f21a6b9450fea939 correct spelling is TriangleStrip (not plural). Currently have to use @ts-ignore to make it work correctly. When using trianglesStrip (according to TS enum), getting issue with rendering.

<Vertices
    // @ts-ignore
    mode={'triangleStrip'} // <--- this working, even though it's "incorrect"
    vertices={vertices}
    textures={uvs}
    blendMode='srcOver'
>
</Vertices>

@wcandillon wcandillon requested review from william-candillon and wcandillon and removed request for wcandillon August 6, 2024 05:43
Copy link
Contributor

@wcandillon wcandillon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I added a test for it

@wcandillon
Copy link
Contributor

I pushed my branch to the origin remote by mistake, you can accept the changes at mrEuler#1

@mrEuler
Copy link
Contributor Author

mrEuler commented Aug 6, 2024

@wcandillon merged that, thanks!

@wcandillon wcandillon merged commit b9a38f0 into Shopify:main Aug 22, 2024
8 of 9 checks passed
@wcandillon
Copy link
Contributor

Thanks @mrEuler :)

Copy link
Contributor

🎉 This issue has been resolved in version 1.3.11 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants