Fix weird bug in AssetSizeAppBlock{CSS,JavaScript} #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charlespwd
force-pushed
the
fix/app-block-size-check-ffs
branch
from
6e44de0 to
f72f5c7
Compare
We were getting "Can't find file size" for assets/app.js errors being logged. That was because the function wasn't being called with an absolute path but with a relative path. For fuck's sake. I refactored our root finding algo for a long time thinking it was the cause. It wasn't. It was this fucking dumb implementation bug. Fixes Shopify/cli#3497
charlespwd
force-pushed
the
fix/app-block-size-check-ffs
branch
from
f72f5c7 to
cace5eb
Compare
|
Fixes Shopify/cli#3344 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were getting "Can't find file size" for assets/app.js errors being
logged. That was because the function wasn't being called with an
absolute path but with a relative path.
For fuck's sake. I refactored our root finding algo for a long time
thinking it was the cause. It wasn't.
It was this fucking dumb implementation bug.
Fixes Shopify/cli#3344
Before you deploy
changeset