Fix theme files not being found on Windows for theme check #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…windows machines due to '\' seperator being passed to glob.
charlespwd
force-pushed
the
justshrey/main
branch
3 times, most recently
from
67be4a7 to
60efe55
Compare
charlespwd
force-pushed
the
justshrey/main
branch
from
60efe55 to
c465226
Compare
|
Thank you! @charlespwd Loved how you have expanded it and created the tests, spec and the changeset! Learnt a lot seeing the changes 👍 . Look forward to contributing more when I can! 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you adding in this PR?
Fixes Shopify/cli#3497
Closes #322
Thank you @justshrey
Before you deploy
changeset