-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add second location for hackerspace drenthe #264
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to https://validator.spaceapi.io/ui/?url=https://mqtt.hackerspace-drenthe.nl/spaceapi-emmen
lat
and lon
in the location
object are missing.
Also consider adding support for v14. See https://spaceapi.io/ for an example which is both v0.13 and v14 compatible. I think you can just add |
i tried this, but now the validator gives a blank page when i check our url. (this one is still fine: https://validator.spaceapi.io/ui/?url=https://mqtt.hackerspace-drenthe.nl/spaceapi) |
aha: Validate failed: error: json: cannot unmarshal string into Go struct field spaceAPIVersion.api_compatibility of type []string |
ok i fixed it. it turns out the validator doesnt like it when its a string instead of an array. it also doesnt like ["0.14"] instead of ["14"]. The validator server returns a 500 but this is not properly handled in the javascript browser part. Maybe someone should fix it, so it will show the server error on the page. |
@psy0rz Yeah sorry the validator is a bit rough when errors happen 🙁 see also SpaceApi/validator#64. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Data looks good now, thanks 🙂
We have a second location. Its the same organisation and members, but a separate location/spacestate/etc