Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved code for the QR Generator #100

Merged
merged 1 commit into from
Oct 5, 2024
Merged

Improved code for the QR Generator #100

merged 1 commit into from
Oct 5, 2024

Conversation

djv554
Copy link
Contributor

@djv554 djv554 commented Oct 4, 2024

Pull Request for PyVerse 💡

Issue Title: Improve QR Generator code by adding new features

  • Info about the related issue (Aim of the project) : To enhance the code by adding new features and improve the efficiency.

  • Name: Deanne Vaz

  • GitHub ID: https://github.com/djv554

  • Email ID: vazdeanne5@gmail.com

  • Idenitfy yourself: (Mention in which program you are contributing in. Eg. For a WoB 2024 participant it's, WoB Participant)
    Contributor at GSSoC extd and Hacktoberfest

Closes: #71

Describe the add-ons or changes you've made 📃

I have implemented the following features in the code

  1. User Input Handling: includes functions to get user input for the URL, fill color, background color, and box size.
  2. Validation Functions: ensures that the URL format, colour and the box size are correct before proceeding.
  3. Error Handling: It raises ValueError for invalid inputs and RuntimeError for issues during QR code generation
  4. Modularity: divided the code into separate functions to increase readability and maintainability.

Type of change ☑️

What sort of change have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested? ⚙️

Ran it locally

Checklist: ☑️

  • My code follows the guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly wherever it was hard to understand.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added things that prove my fix is effective or that my feature works.
  • Any dependent changes have been merged and published in downstream modules.

Copy link

github-actions bot commented Oct 4, 2024

👋 Thank you for opening this pull request! We're excited to review your contribution. Please give us a moment, and we'll get back to you shortly!

Feel free to join our community on Discord to discuss more!

@github-actions github-actions bot requested a review from UTSAVS26 October 4, 2024 16:37
@djv554 djv554 changed the title Add files via upload Improved code for the QR Generator Oct 4, 2024
@UTSAVS26
Copy link
Owner

UTSAVS26 commented Oct 5, 2024

@djv554 please link the issue as well.

@djv554
Copy link
Contributor Author

djv554 commented Oct 5, 2024

@UTSAVS26 updated

@UTSAVS26 UTSAVS26 merged commit 9ea3aca into UTSAVS26:main Oct 5, 2024
1 check passed
@djv554
Copy link
Contributor Author

djv554 commented Oct 6, 2024

@UTSAVS26 Please add the appropriate labels gssoc-ext and hacktober-accepted.

@UTSAVS26 UTSAVS26 added Contributor Denotes issues or PRs submitted by contributors to acknowledge their participation. Status: Approved ✔️ PRs that have passed review and are approved for merging. gssoc-ext hacktoberfest hacktoberfest-accepted level1 labels Oct 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Contributor Denotes issues or PRs submitted by contributors to acknowledge their participation. gssoc-ext hacktoberfest hacktoberfest-accepted level1 Status: Approved ✔️ PRs that have passed review and are approved for merging.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🧑‍💻: Improve the QR Generator code by adding new features
3 participants