Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update KBCquiz.py #1121

Closed
wants to merge 1 commit into from
Closed

Update KBCquiz.py #1121

wants to merge 1 commit into from

Conversation

saanvi23454
Copy link

@saanvi23454 saanvi23454 commented Nov 8, 2024

fixed issues with display (alligning lines to the right as well as left).

on quitting or wrong answer, correct answer also shown now

Pull Request for PyVerse 💡

Requesting to submit a pull request to the PyVerse repository.


Issue Title

Please enter the title of the issue related to your pull request.
fixed display, increased functionality

  • I have provided the issue title.

Info about the Related Issue

What's the goal of the project?
Describe the aim of the project.

  • I have described the aim of the project.

Name

Please mention your name.
Saanvi S

  • I have provided my name.

GitHub ID

Please mention your GitHub ID.
saanvi23454

  • I have provided my GitHub ID.

Email ID

Please mention your email ID for further communication.
saanvisinghofficial@gmail.com

  • I have provided my email ID.

Identify Yourself

Mention in which program you are contributing (e.g., WoB, GSSOC, SSOC, SWOC).
GSSOC contributor

  • I have mentioned my participant role.

Closes

Enter the issue number that will be closed through this PR.
*Closes: #1122 *

  • I have provided the issue number.

Describe the Add-ons or Changes You've Made

Give a clear description of what you have added or modified.
Fixed * and - in display to align on the right as well
Added printing correct answer on quitting or wrong answer by user

  • I have described my changes.

Type of Change

Select the type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • [ yes] New feature (non-breaking change which adds functionality)
  • [ yes] Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Describe how your changes have been tested.
visually

  • I have described my testing process.

Checklist

Please confirm the following:

  • My code follows the guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly wherever it was hard to understand.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added things that prove my fix is effective or that my feature works.
  • Any dependent changes have been merged and published in downstream modules.

fixed issues with display (alligning lines to the right as well as left).

on quitting or wrong answer, correct answer also shown now
Copy link

github-actions bot commented Nov 8, 2024

👋 Thank you for opening this pull request! We're excited to review your contribution. Please give us a moment, and we'll get back to you shortly!

Feel free to join our community on Discord to discuss more!

@ruhi47 ruhi47 self-requested a review November 8, 2024 19:40
Copy link

@ruhi47 ruhi47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issue number mentioned in the PR. Please mention it or else I will have to close this.
@saanvi23454 .
Thanks!

@saanvi23454
Copy link
Author

Didn't raise the issue I saw in the code before the corrections, is it ok to create now ? sorry about the confusion

@saanvi23454
Copy link
Author

done

@ruhi47
Copy link

ruhi47 commented Nov 8, 2024

@UTSAVS26 Please review this.

@UTSAVS26 UTSAVS26 closed this Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🧑‍💻: [Modify / Add Code] KBC Quiz
3 participants