Add stack implementation with stack.py and readme.me #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Thank you for opening this pull request! We're excited to review your contribution. Please give us a moment, and we'll get back to you shortly! |
|
@Charul00 please add the correct issue |
i have added check please |
|
add a test/example for checking if and how the stack works for different data types |
TheChaoticor
requested changes
Oct 2, 2024
in readme file right? |
|
no,in the code. Add a simple test/example of atleast two different data types and try with strings too and comment its output |
done please check now |
|
merged,good work |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for PyVerse 💡
Issue Title: Implement Stack Data Structure
Info about the related issue (Aim of the project): This project aims to implement a stack data structure using Python, providing essential operations such as push, pop, peek, and is_empty. The stack will be demonstrated through a practical implementation, enhancing understanding of LIFO (Last In First Out) behavior in data structures.
Name: Charul Chim
GitHub ID: Charul00
Email ID: charulchim18@gmail.com
Identify yourself: gssoc-ext contributor
Closes: #14
Describe the add-ons or changes you've made 📃
In this pull request, I have created a stack folder that contains:
stack.py: This file implements the stack data structure with methods to perform push, pop, peek, and check if the stack is empty.
README.md: This file provides an overview of the stack data structure, its properties, and a guide on how to use the implemented code. It also includes explanations for the various methods in the stack.py file, making it easier for users to understand the implementation.
Type of change ☑️
What sort of change have you made:
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Code style update (formatting, local variables)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update
How Has This Been Tested? ⚙️
The stack implementation has been tested by performing a series of push and pop operations to ensure the Last In First Out (LIFO) property is maintained. Each method has been invoked with various inputs to validate functionality, and the results have been printed for verification.
Checklist: ☑️
My code follows the guidelines of this project.
I have performed a self-review of my own code.
I have commented my code, particularly wherever it was hard to understand.
I have made corresponding changes to the documentation.
My changes generate no new warnings.
I have added things that prove my fix is effective or that my feature works.
Any dependent changes have been merged and published in downstream modules.