(#757) Allow Users to Manually Edit the Generated Email in Cold Email Generator App #765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow users to manually edit the generated email
|
👋 Thank you for opening this pull request! We're excited to review your contribution. Please give us a moment, and we'll get back to you shortly! Feel free to join our community on Discord to discuss more! |
github-actions
bot
requested review from
ruhi47,
shaansuraj,
TheChaoticor and
UTSAVS26
UTSAVS26
added
Contributor
ruhi47
suggested changes
Oct 24, 2024
| with col3: | ||
| if st.button("Copy to Clipboard"): | ||
| st.markdown(f"<script>navigator.clipboard.writeText(`{edited_email}`);</script>") | ||
| st.success("Email copied to clipboard!") |
There was a problem hiding this comment.
Try adding a few seconds of delay before the message disappears in the event of "Copy to Clipboard". Otherwise looks good. Update this and I will approve the PR. Thank you.
| with col2: | ||
| if st.button("Download Email"): | ||
| # Save the email as a text file for download | ||
| st.download_button("Download Email", edited_email, file_name="email.txt", mime="text/plain") |
There was a problem hiding this comment.
Just make a few checks, there are some issues when downloading email (no .txt file is saved) but the code is fine no improvement required.
ruhi47
added
the
Status: Requested Changes⚙️
|
@ruhi47 Change request implemented, please review and merge . |
github-actions
bot
force-pushed
the
main
branch
2 times, most recently
from
6a1fc16 to
331cbb0
Compare
Resolved the issues with the 'Save Draft', 'Copy to Clipboard', and 'Download' buttons.
ruhi47
added
Status: Approved ✔️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow users to manually edit the generated email
Pull Request for PyVerse 💡
Requesting to submit a pull request to the PyVerse repository.
Issue Title
Allow Users to Manually Edit the Generated Email in Cold Email Generator App
Info about the Related Issue
This pull request aims to enhance the Cold Email Generator app by allowing users to manually edit the generated email and providing multiple options for further actions. These actions include saving the email as a draft, downloading it as a .txt file, and copying it to the clipboard.
Name
SHREYAS SHRENIK PARAJ PATIL
GitHub ID
@shreyasparaj
Email ID
shreyasparaj1@gmail.com
Identify Yourself
GSSOC CONTRIBUTOR
Closes
Closes: #757
Describe the Add-ons or Changes You've Made
Type of Change
Select the type of change:
How Has This Been Tested?
Verified the text area correctly displays the initial generated email.
Tested the "Save as Draft" feature by storing the edited email in the session state and retrieving it.
Ensured the "Download" button correctly saves the content as a .txt file.
Checked the functionality of the "Copy to Clipboard" button for accuracy.
I have described my testing process.
Checklist
Please confirm the following: