Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exchange ease feature #957

Closed
wants to merge 5 commits into from

Conversation

amrutha-m206
Copy link
Contributor

@amrutha-m206 amrutha-m206 commented Oct 30, 2024

Pull Request for PyVerse 💡

Requesting to submit a pull request to the PyVerse repository.


Issue Title

Please enter the title of the issue related to your pull request.

[Code Addition Request]: Currency Converter

  • I have provided the issue title.

Info about the Related Issue

What's the goal of the project?
The aim of the project is to provide a simple and reliable tool for users to convert currencies using real time exchange rates.

  • I have described the aim of the project.

Name

Please mention your name.
Amrutha M

  • I have provided my name.

GitHub ID

Please mention your GitHub ID.
amrutha-m206.

  • I have provided my GitHub ID.

Email ID

Please mention your email ID for further communication.
amrutha.m273@gmail.com

  • I have provided my email ID.

Identify Yourself

Mention in which program you are contributing (e.g., WoB, GSSOC, SSOC, SWOC).
gssoc-ext, hacktoberfest, hacktoberfest-accepted

  • I have mentioned my participant role.

Closes

Enter the issue number that will be closed through this PR.
Closes: #955

  • I have provided the issue number.

Describe the Add-ons or Changes You've Made

Give a clear description of what you have added or modified.
A simple web interface which allows users to input amounts and select currencies for conversion, enhancing usability. An external API was integrated to fetch real-time exchange rates along with error handling for invalid inputs, ensuring accurate conversions

Screenshot 2024-10-30 160437
Screenshot 2024-10-30 160449
Screenshot 2024-10-30 160502

  • I have described my changes.

Type of Change

Select the type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Describe how your changes have been tested.
Has been tested manually with inputs and results have been verified.

  • I have described my testing process.

Checklist

Please confirm the following:

  • My code follows the guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly wherever it was hard to understand.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added things that prove my fix is effective or that my feature works.
  • Any dependent changes have been merged and published in downstream modules.

Copy link

👋 Thank you for opening this pull request! We're excited to review your contribution. Please give us a moment, and we'll get back to you shortly!

Feel free to join our community on Discord to discuss more!

@UTSAVS26 UTSAVS26 added Contributor Denotes issues or PRs submitted by contributors to acknowledge their participation. Status: Review Ongoing 🔄 PR is currently under review and awaiting feedback from reviewers. level1 gssoc-ext hacktoberfest labels Oct 30, 2024
@github-actions github-actions bot force-pushed the main branch 2 times, most recently from 774a759 to f014edc Compare October 31, 2024 02:44
@amrutha-m206
Copy link
Contributor Author

@UTSAVS26 Can this be merged if the review is completed?

@UTSAVS26
Copy link
Owner

@UTSAVS26 Can this be merged if the review is completed?

Wait for sometime as mentors are reviewing too.

Copy link

@ruhi47 ruhi47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @amrutha-m206 ,
I would appreciate if you can provide a README.md file and work on the structure of the project. Will review after you push new changes. Let me know if you need help.
Thank you!

@ruhi47 ruhi47 added the Status: Requested Changes⚙️ Indicates that a reviewer has requested changes to a PR before it can be approved. label Nov 5, 2024
@github-actions github-actions bot force-pushed the main branch 2 times, most recently from 609b090 to c1dc75e Compare November 7, 2024 02:42
@UTSAVS26 UTSAVS26 closed this Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Contributor Denotes issues or PRs submitted by contributors to acknowledge their participation. gssoc-ext hacktoberfest level1 Status: Requested Changes⚙️ Indicates that a reviewer has requested changes to a PR before it can be approved. Status: Review Ongoing 🔄 PR is currently under review and awaiting feedback from reviewers.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Code Addition Request]: Currency Converter
4 participants